Skip to content

Conversation

spiderxm
Copy link
Collaborator

Support for

  • English
  • German
  • Russian

With menu to toggle between languages
Screenshot 2021-07-14 at 7 43 43 PM
Screenshot 2021-07-14 at 7 43 55 PM
Screenshot 2021-07-14 at 7 44 04 PM

@Ali-Razmjoo
Copy link
Collaborator

Thanks for the PR 👍

  • can you please convert these to YAML instead? you can use this site to convert JSON to YAML. https://www.json2yaml.com/
  • should we also import this library inside the application (CLI)? if yes maybe we can have CLI argv option as well (default english) and have some tests in github CI to check the outputs.

thoughts?

@spiderxm
Copy link
Collaborator Author

yes we can use YAML it will be more clean.

@spiderxm
Copy link
Collaborator Author

for the CLI part i will take a look

@spiderxm
Copy link
Collaborator Author

@Ali-Razmjoo. @dhirensr Please review

@Ali-Razmjoo Ali-Razmjoo changed the base branch from development to elasticsearch July 27, 2021 15:43
@Ali-Razmjoo
Copy link
Collaborator

ignore the error in regard of credential events; we fix that in elasticsearch branch

image

Ali Razmjoo and others added 6 commits July 28, 2021 13:45
@Ali-Razmjoo Ali-Razmjoo merged commit f2965e7 into OWASP:elasticsearch Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants