Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL encoding for extended ASCII characters was producing the wrong re… #189

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

benPearce1
Copy link
Contributor

@benPearce1 benPearce1 commented Aug 7, 2017

Fixes OctopusDeploy/Issues#3718
Added base unit tests around UrlTemplate

@benPearce1 benPearce1 requested a review from droyad August 7, 2017 06:14
@CLAassistant
Copy link

CLAassistant commented Aug 7, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


benpearce1 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@benPearce1 benPearce1 requested a review from markryd August 8, 2017 03:31
Copy link
Contributor

@markryd markryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at the history, and pre-netcore we were using Uri.HexEscape, which we then ported, so presumably this was always broken. EscapeDataString and HexEscape give different values for standard chars (HexEscape converts them to hex anyway) but I guess if it works with Octopus Server then we weren't relying on that ¯_(ツ)_/¯

@benPearce1 benPearce1 merged commit a7e3e70 into master Aug 9, 2017
@benPearce1 benPearce1 deleted the bug-nonasciiencoding branch August 9, 2017 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants