Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AgentlessEndpointResource, it's a weird abstraction #528

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Remove AgentlessEndpointResource, it's a weird abstraction #528

merged 1 commit into from
Jun 11, 2020

Conversation

flin-8
Copy link
Contributor

@flin-8 flin-8 commented Jun 8, 2020 •
edited
Loading

We've removed this on the Server side, so it makes sense to remove it here too.
Can we safely remove this intermediate class without breaking people?

@flin-8 flin-8 requested a review from slewis74 June 8, 2020 22:52
@flin-8 flin-8 self-assigned this Jun 8, 2020
@flin-8 flin-8 marked this pull request as ready for review June 11, 2020 09:09
@flin-8 flin-8 force-pushed the frank/agentlessresource branch from 1aff317 to ddcba14 Compare June 11, 2020 09:13
slewis74
slewis74 approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@slewis74 slewis74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@flin-8 flin-8 merged commit 786d3a4 into master Jun 11, 2020
@flin-8 flin-8 deleted the frank/agentlessresource branch June 11, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slewis74 slewis74 slewis74 approved these changes

Assignees

@flin-8 flin-8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flin-8 @slewis74