Merge from Office-Addin-TaskPane #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excel Desktop: this launch config will launch Excel but the task pane cannot be debugged using VS Code. Instead, use Edge DevTools or Visual Studio to attach to the task pane and debug. Office Online (Edge): this launch config will allow you to debug the task pane code but requires manual configuration first. Replace the url with the share link to an Office Online document. After debugging is started, you will need to upload the manifest to insert the add-in into the document. You can then set breakpoints in the source code, and should hit them when the code is executed.
Update readme with link to JavaScript version of template
Updated office-addin-debugging package to v2.0.0 which supports reading package.json config for values rather than requiring command line options to be set. Allows the appType to be set so that the debugging start command can do the appropriate thing for each type of app.
I've updated the source code so that it can detect and run the appropriate code for each Office app host. The manifest contains support for all hosts except for Outlook. I had problems merging it in, and will try again later, or we will need to have a separate manifest.outlook.xml file. I've updated debugging support so that `npm start -- --app word` will work, as well as using the VS Code launch config `Word Desktop` (using Start Without Debugging because the integrated VSCode debugger cannot debug the taskpane webview). After launch, you instead use Edge DevTools or Visual Studio to debug. There is also a VSCode debug config for `Office Online (Edge)`. You can paste the share url of the Office document when prompted on F5 and use the integrated debugger to it running in Edge. * Add code for each host * add multiple hosts to manifest * Update sideload npm scripts to allow choosing which app * Update VSCode launch configs for Excel/PowerPoint/Word * add VSCode debug config for Chrome * add debugging doc * update office-addin-debugging package
TCourtneyOwen
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge changes from https://github.com/OfficeDev/Office-Addin-TaskPane.