-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend RequestAppAudioHandling to support for audio device selection sync #2030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just two minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending tests being fixed/passing
Will approve once the tests are passing |
@shrshindeMSFT @KangxuanYe The PR for meta-os has been merged. All checks have passed. Mind take a look at this again? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Releasing2.18.0 * Update packages/teams-js/CHANGELOG.md Co-authored-by: Trevor Harris <trharris@microsoft.com> * Update packages/teams-js/CHANGELOG.md Co-authored-by: Trevor Harris <trharris@microsoft.com> * Removed revert from changelog, since this was re-added * Revert "Extend RequestAppAudioHandling to support for audio device se… (#2069) * Revert "Extend RequestAppAudioHandling to support for audio device selection sync (#2030)" This reverts commit 6f23f92. * Change files * Change files * Extend RequestAppAudioHandling to support for audio device selection sync (#2070) * extend RequestAppAudioHandlingParams by adding audioDeviceSelectionChangedCallback * Remove old changefile * Change files * Updated changefile * Update contact info in changefile --------- Co-authored-by: Xukai Wu <xuwu@microsoft.com> * Updated hash values and changelog due to changes merged in from main --------- Co-authored-by: jadahiya-MSFT <jadahiya-MSFT@users.noreply.github.com> Co-authored-by: Trevor Harris <trharris@microsoft.com> Co-authored-by: AE ( ͡ಠ ʖ̯ ͡ಠ) <36546967+AE-MS@users.noreply.github.com> Co-authored-by: Xukai Wu <xuwu@microsoft.com>
* Releasing 2.18.0 (#2068) * Releasing2.18.0 * Update packages/teams-js/CHANGELOG.md Co-authored-by: Trevor Harris <trharris@microsoft.com> * Update packages/teams-js/CHANGELOG.md Co-authored-by: Trevor Harris <trharris@microsoft.com> * Removed revert from changelog, since this was re-added * Revert "Extend RequestAppAudioHandling to support for audio device se… (#2069) * Revert "Extend RequestAppAudioHandling to support for audio device selection sync (#2030)" This reverts commit 6f23f92. * Change files * Change files * Extend RequestAppAudioHandling to support for audio device selection sync (#2070) * extend RequestAppAudioHandlingParams by adding audioDeviceSelectionChangedCallback * Remove old changefile * Change files * Updated changefile * Update contact info in changefile --------- Co-authored-by: Xukai Wu <xuwu@microsoft.com> * Updated hash values and changelog due to changes merged in from main --------- Co-authored-by: jadahiya-MSFT <jadahiya-MSFT@users.noreply.github.com> Co-authored-by: Trevor Harris <trharris@microsoft.com> Co-authored-by: AE ( ͡ಠ ʖ̯ ͡ಠ) <36546967+AE-MS@users.noreply.github.com> Co-authored-by: Xukai Wu <xuwu@microsoft.com> * Change files --------- Co-authored-by: jadahiya-MSFT <jadahiya-MSFT@users.noreply.github.com> Co-authored-by: Trevor Harris <trharris@microsoft.com> Co-authored-by: AE ( ͡ಠ ʖ̯ ͡ಠ) <36546967+AE-MS@users.noreply.github.com> Co-authored-by: Xukai Wu <xuwu@microsoft.com>
Description
This is a continuous PR of the original PR by shilcare. There is another outdated PR from a fork here, change to this branch PR because of security issues.
Purpose
Give Teams apps the ability to use Teams' audio devices settings, like play audio on the device that user selected in Teams.
Details
Add a callback method to
RequestAppAudioHandling
.RequestAppAudioHandling
with this callback, the callback will be called immediately with Teams' current audio device labels. The app can use this info to initialize and select the corresponding audio devices.Main changes in the PR:
audioDeviceSelectionChangedCallback
toRequestAppAudioHandlingParams
which is used inmeeting.requestAppAudioHandling
startAppAudioHandling
stopAppAudioHandling
Validation
Validation performed:
To make this work properly, we also need code changes in some internal repos. We have built a Teams container with those changes.
meeting.requestAppAudioHandling
is called. And also get called after device is changed in Teams settings. The payload is correct too.Unit Tests added:
Yes
End-to-end tests added:
requestAppAudioHandling API Call - register audioDeviceSelectionChanged Handler
Additional Requirements
Change file added:
No.
pnpm changefile
says No change files are needed.Related PRs:
Next/remaining steps:
Close original PR because duplicated and outdated.
Close fork PR because duplicated and outdated.