-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend RequestAppAudioHandling to support for audio device selection sync #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadahiya-MSFT
approved these changes
Nov 30, 2023
erinha
approved these changes
Nov 30, 2023
KangxuanYe
approved these changes
Nov 30, 2023
Merged
jadahiya-MSFT
added a commit
that referenced
this pull request
Dec 1, 2023
* Releasing2.18.0 * Update packages/teams-js/CHANGELOG.md Co-authored-by: Trevor Harris <trharris@microsoft.com> * Update packages/teams-js/CHANGELOG.md Co-authored-by: Trevor Harris <trharris@microsoft.com> * Removed revert from changelog, since this was re-added * Revert "Extend RequestAppAudioHandling to support for audio device se… (#2069) * Revert "Extend RequestAppAudioHandling to support for audio device selection sync (#2030)" This reverts commit 6f23f92. * Change files * Change files * Extend RequestAppAudioHandling to support for audio device selection sync (#2070) * extend RequestAppAudioHandlingParams by adding audioDeviceSelectionChangedCallback * Remove old changefile * Change files * Updated changefile * Update contact info in changefile --------- Co-authored-by: Xukai Wu <xuwu@microsoft.com> * Updated hash values and changelog due to changes merged in from main --------- Co-authored-by: jadahiya-MSFT <jadahiya-MSFT@users.noreply.github.com> Co-authored-by: Trevor Harris <trharris@microsoft.com> Co-authored-by: AE ( ͡ಠ ʖ̯ ͡ಠ) <36546967+AE-MS@users.noreply.github.com> Co-authored-by: Xukai Wu <xuwu@microsoft.com>
jadahiya-MSFT
added a commit
that referenced
this pull request
Dec 6, 2023
* Releasing 2.18.0 (#2068) * Releasing2.18.0 * Update packages/teams-js/CHANGELOG.md Co-authored-by: Trevor Harris <trharris@microsoft.com> * Update packages/teams-js/CHANGELOG.md Co-authored-by: Trevor Harris <trharris@microsoft.com> * Removed revert from changelog, since this was re-added * Revert "Extend RequestAppAudioHandling to support for audio device se… (#2069) * Revert "Extend RequestAppAudioHandling to support for audio device selection sync (#2030)" This reverts commit 6f23f92. * Change files * Change files * Extend RequestAppAudioHandling to support for audio device selection sync (#2070) * extend RequestAppAudioHandlingParams by adding audioDeviceSelectionChangedCallback * Remove old changefile * Change files * Updated changefile * Update contact info in changefile --------- Co-authored-by: Xukai Wu <xuwu@microsoft.com> * Updated hash values and changelog due to changes merged in from main --------- Co-authored-by: jadahiya-MSFT <jadahiya-MSFT@users.noreply.github.com> Co-authored-by: Trevor Harris <trharris@microsoft.com> Co-authored-by: AE ( ͡ಠ ʖ̯ ͡ಠ) <36546967+AE-MS@users.noreply.github.com> Co-authored-by: Xukai Wu <xuwu@microsoft.com> * Change files --------- Co-authored-by: jadahiya-MSFT <jadahiya-MSFT@users.noreply.github.com> Co-authored-by: Trevor Harris <trharris@microsoft.com> Co-authored-by: AE ( ͡ಠ ʖ̯ ͡ಠ) <36546967+AE-MS@users.noreply.github.com> Co-authored-by: Xukai Wu <xuwu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was originally committed with PR #2030. It had to be reverted with PR #2069. This PR fixes the problem (adds version constraint to two new tests added in
meeting.json
). Other than that change, everything in this PR is identical to #2030. You can verify this by runninggit diff 6f23f92877165e7909c202d039aa0db6fa481248 origin/bingliang/audio-device-selection-sync
which will compare the commit of the original PR with this branchDescription
This is a continuous PR of the original PR by shilcare. There is another outdated PR from a fork here, change to this branch PR because of security issues.
Purpose
Give Teams apps the ability to use Teams' audio devices settings, like play audio on the device that user selected in Teams.
Details
Add a callback method to
RequestAppAudioHandling
.RequestAppAudioHandling
with this callback, the callback will be called immediately with Teams' current audio device labels. The app can use this info to initialize and select the corresponding audio devices.Main changes in the PR:
audioDeviceSelectionChangedCallback
toRequestAppAudioHandlingParams
which is used inmeeting.requestAppAudioHandling
startAppAudioHandling
stopAppAudioHandling
Validation
Validation performed:
To make this work properly, we also need code changes in some internal repos. We have built a Teams container with those changes.
meeting.requestAppAudioHandling
is called. And also get called after device is changed in Teams settings. The payload is correct too.Unit Tests added:
Yes
End-to-end tests added:
requestAppAudioHandling API Call - register audioDeviceSelectionChanged Handler
Additional Requirements
Change file added:
No.
pnpm changefile
says No change files are needed.Related PRs:
Next/remaining steps:
Close original PR because duplicated and outdated.
Close fork PR because duplicated and outdated.