Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow BTC In Crowdsales #399

Conversation

Projects
None yet
2 participants
@zathras-crypto
Copy link

commented Jul 10, 2016

This PR enables the use of Bitcoin as a funding source in crowdsales.

This is currently a WIP/placeholder, but should be functional.

Current test results:

Preparing a test environment...
   * Starting a fresh regtest daemon
   * Preparing some mature testnet BTC
   * Obtaining a master address to work with
   * Funding the address with some testnet BTC for fees
   * Participating in the Exodus crowdsale to obtain some OMNI
   * Generating addresses to use

Testing a crowdsale using BTC before activation...
   * Creating an indivisible test property and opening a crowdsale
     # Checking the transaction was invalid... PASS

Activating v2 crowdsales (allow BTC)... 
   * Sending the activation
     # Checking the activation transaction was valid... PASS
   * Mining 10 blocks to forward past the activation block
     # Checking the activation went live as expected... PASS

Testing crowdsales using BTC after activation...

Testing an indivisible BTC crowdsale...
   * Creating an indivisible test property and opening a crowdsale
     # Checking the transaction was valid... PASS

Testing sending a BTC payment to the crowdsale...
   * Sending some BTC to mkxYY4KGgyBKgsXqgjEj75bsh4yxd2Kx1n
   * Sending some BTC from mkxYY4KGgyBKgsXqgjEj75bsh4yxd2Kx1n to the crowdsale
     # Checking the transaction was valid... PASS
     # Checking the payment was linked to the correct transaction... PASS
     # Checking the payment was linked to the correct recipient... PASS
     # Checking the payment amount was 0.1 BTC... PASS
     # Checking the sending address now has 100 of property 3... PASS
     # Checking the transaction is listed in crowdsale participants... PASS
     # Checking the crowdsale amount raised is now 0.1 BTC... PASS
     # Checking the amount of tokens issued to users is now 100... PASS
     # Checking the amount of tokens issued to uthe isuser is still 0... PASS

Testing a divisible BTC crowdsale...
   * Sending some BTC to mz41y8JmRuU3JujMx5cua2rHATsy3nfsj9
   * Sending some BTC to msbm3v3HUtJzpL9u5iZ2uGUVv5CPySAzqF
   * Creating a divisible test property and opening a crowdsale
     # Checking the transaction was valid... PASS
   * Sending some BTC from msbm3v3HUtJzpL9u5iZ2uGUVv5CPySAzqF to the crowdsale
     # Checking the transaction was valid... PASS
     # Checking the payment was linked to the correct transaction... PASS
     # Checking the payment was linked to the correct recipient... PASS
     # Checking the payment amount was 0.1 BTC... PASS
     # Checking the sending address now has 100.0 of property 4... PASS
     # Checking the transaction is listed in crowdsale participants... PASS
     # Checking the crowdsale amount raised is now 0.1 BTC... PASS
     # Checking the amount of tokens issued to users is now 100.0... PASS
     # Checking the amount of tokens issued to uthe isuser is still 0... PASS

####################
#  Summary:        #
#    Passed = 23   #
#    Failed = 0    #
####################

@zathras-crypto zathras-crypto changed the title 0.0.11 z allow btc in crowdsales 0.0.11 Allow BTC In Crowdsales Jul 10, 2016

@dexX7

This comment has been minimized.

Copy link
Member

commented Jul 10, 2016

Hey @zathras-crypto, thanks for pushing this!

I'm a bit surprised by the title: are you suggesting we should adopt this for 0.0.11?

@zathras-crypto zathras-crypto changed the title 0.0.11 Allow BTC In Crowdsales Allow BTC In Crowdsales Jul 10, 2016

@zathras-crypto

This comment has been minimized.

Copy link
Author

commented Jul 10, 2016

Sorry my bad, that came from my branch name - nope not intended for 0.0.11. I've fixed the title now :)

dexX7 pushed a commit that referenced this pull request Jan 23, 2017

Squashed 'src/secp256k1/' changes from 6c527ec..8225239
8225239 Merge #433: Make the libcrypto detection fail the newer API.
12de863 Make the libcrypto detection fail the newer API.
2928420 Merge #427: Remove Schnorr from travis as well
8eecc4a Remove Schnorr from travis as well
a8abae7 Merge #310: Add exhaustive test for group functions on a low-order subgroup
b4ceedf Add exhaustive test for verification
83836a9 Add exhaustive tests for group arithmetic, signing, and ecmult on a small group
20b8877 Add exhaustive test for group functions on a low-order subgroup
80773a6 Merge #425: Remove Schnorr experiment
e06e878 Remove Schnorr experiment
04c8ef3 Merge #407: Modify parameter order of internal functions to match API parameter order
6e06696 Merge #411: Remove guarantees about memcmp-ability
40c8d7e Merge #421: Update scalar_4x64_impl.h
a922365 Merge #422: Restructure nonce clearing
3769783 Restructure nonce clearing
0f9e69d Restructure nonce clearing
9d67afa Update scalar_4x64_impl.h
7d15cd7 Merge #413: fix auto-enabled static precompuatation
00c5d2e fix auto-enabled static precompuatation
91219a1 Remove guarantees about memcmp-ability
7a49cac Merge #410: Add string.h include to ecmult_impl
0bbd5d4 Add string.h include to ecmult_impl
353c1bf Fix secp256k1_ge_set_table_gej_var parameter order
541b783 Fix secp256k1_ge_set_all_gej_var parameter order
7d893f4 Fix secp256k1_fe_inv_all_var parameter order
c5b32e1 Merge #405: Make secp256k1_fe_sqrt constant time
926836a Make secp256k1_fe_sqrt constant time
e2a8e92 Merge #404: Replace 3M + 4S doubling formula with 2M + 5S one
8ec49d8 Add note about 2M + 5S doubling formula
5a91bd7 Merge #400: A couple minor cleanups
ac01378 build: add -DSECP256K1_BUILD to benchmark_internal build flags
a6c6f99 Remove a bunch of unused stdlib #includes
65285a6 Merge #403: configure: add flag to disable OpenSSL tests
a9b2a5d configure: add flag to disable OpenSSL tests
b340123 Merge #402: Add support for testing quadratic residues
e6e9805 Add function for testing quadratic residue field/group elements.
efd953a Add Jacobi symbol test via GMP
fa36a0d Merge #401: ecmult_const: unify endomorphism and non-endomorphism skew cases
c6191fd ecmult_const: unify endomorphism and non-endomorphism skew cases
0b3e618 Merge #378: .gitignore build-aux cleanup
6042217 Merge #384: JNI: align shared files copyright/comments to bitcoinj's
24ad20f Merge #399: build: verify that the native compiler works for static precomp
b3be852 Merge #398: Test whether ECDH and Schnorr are enabled for JNI
aa0b1fd build: verify that the native compiler works for static precomp
eee808d Test whether ECDH and Schnorr are enabled for JNI
7b0fb18 Merge #366: ARM assembly implementation of field_10x26 inner (rebase of #173)
001f176 ARM assembly implementation of field_10x26 inner
0172be9 Merge #397: Small fixes for sha256
3f8b78e Fix undefs in hash_impl.h
2ab4695 Fix state size in sha256 struct
6875b01 Merge #386: Add some missing `VERIFY_CHECK(ctx != NULL)`
2c52b5d Merge #389: Cast pointers through uintptr_t under JNI
43097a4 Merge #390: Update bitcoin-core GitHub links
31c9c12 Merge #391: JNI: Only call ecdsa_verify if its inputs parsed correctly
1cb2302 Merge #392: Add testcase which hits additional branch in secp256k1_scalar_sqr
d2ee340 Merge #388: bench_ecdh: fix call to secp256k1_context_create
093a497 Add testcase which hits additional branch in secp256k1_scalar_sqr
a40c701 JNI: Only call ecdsa_verify if its inputs parsed correctly
faa2a11 Update bitcoin-core GitHub links
47b9e78 Cast pointers through uintptr_t under JNI
f36f9c6 bench_ecdh: fix call to secp256k1_context_create
bcc4881 Add some missing `VERIFY_CHECK(ctx != NULL)` for functions that use `ARG_CHECK`
6ceea2c align shared files copyright/comments to bitcoinj's
70141a8 Update .gitignore
7b549b1 Merge #373: build: fix x86_64 asm detection for some compilers
bc7c93c Merge #374: Add note about y=0 being possible on one of the sextic twists
e457018 Merge #364: JNI rebased
86e2d07 JNI library: cleanup, removed unimplemented code
3093576 JNI library
bd2895f Merge pull request #371
e72e93a Add note about y=0 being possible on one of the sextic twists
3f8fdfb build: fix x86_64 asm detection for some compilers
e5a9047 [Trivial] Remove double semicolons
c18b869 Merge pull request #360
3026daa Merge pull request #302
03d4611 Add sage verification script for the group laws
a965937 Merge pull request #361
83221ec Add experimental features to configure
5d4c5a3 Prevent damage_array in the signature test from going out of bounds.
419bf7f Merge pull request #356
03d84a4 Benchmark against OpenSSL verification

git-subtree-dir: src/secp256k1
git-subtree-split: 8225239
@dexX7

This comment has been minimized.

Copy link
Member

commented Jan 30, 2018

Given this PR is outdated and needs further review, it's going to be closed for now.

@dexX7 dexX7 closed this Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.