Remove generic usage #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joltras
added
documentation
TheMeinerLP
approved these changes
Jul 9, 2025
Joltras
added a commit
that referenced
this pull request
Jul 9, 2025
* Add license file * Update license file * Allow auto updates for patches * Update dependency gradle to v8.14.1 (#12) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency gradle to v8.14.2 (#13) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Remove final usage to allow custom implementations of the given event classes * Trigger Build * Update dependency gradle to v8.14.3 (#14) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Add support for Minecrat 1.21.5 (#15) * Update bom and aves version * Update artifact from Minestom --------- Co-authored-by: theEvilReaper <steffenwx@gmail.com> * Remove generic usage (#16) * Remove generic value usage * Update test base to reflect the flattened structure * Rename class to reflect their context usage * Add new methods * Override equals and hashcode * Rename class * Add tests for the service class * Remove generic mention in the documentation * Update version number --------- Co-authored-by: theEvilReaper <steffenwx@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
While the original use of generics in the
SetupDataclass was well-intentioned, the implementation introduced some drawbacks that made usage more difficult than usual. This pull request removes the use of generics from theSetupDatainterface and from all related classes. Since Java introduced smart casts, it is now easier to use them instead of generics for this purpose. Additionally, the service can now store different implementations within a single instance, eliminating the need for one instance per context.Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.