sync #1
Merged
sync #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I203af5227ecfee8c9e6b0f4985f68e38a18553c0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125203 Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Dmitry Stefantsov <dmitryas@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Change-Id: If3e85c8cc6a92cdafe146769628ea5c11a5bfcab Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125362 Reviewed-by: Leaf Petersen <leafp@google.com> Commit-Queue: Kallen Tu <kallentu@google.com>
This will make the nnbd-ddc bot green again. To properly support compiling these packages in the future, we need to either migrate them or add to the CFE the machanism to select whether a package is opt-out. Change-Id: Ia8c5fa1a8000e233af20c87e877e2c666cb4354e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125420 Auto-Submit: Sigmund Cherem <sigmund@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com> Reviewed-by: Nicholas Shahan <nshahan@google.com>
Change-Id: I29545fe358282aa05dee10ed7ff5e86ea899581e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125222 Commit-Queue: Mike Fairhurst <mfairhurst@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Paul Berry <paulberry@google.com>
Change-Id: I048607903ba15f604a9d0784b75061ac0d0d397c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125305 Commit-Queue: Fizaa Luthra <fizaaluthra@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com> Reviewed-by: Aart Bik <ajcbik@google.com>
…ng constructors. Change-Id: I4b60a2bea125089d86e2368b3e674adf5ef402aa Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125460 Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Change-Id: I0502bad1c57af358453c78d27fe738880beb7b4e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125021 Reviewed-by: Leaf Petersen <leafp@google.com> Commit-Queue: Kallen Tu <kallentu@google.com>
Helps with #39247 Change-Id: I3bb7b25c73d58fc49260d6e3019b58b2f3f6b80a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125440 Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Paul Berry <paulberry@google.com>
…rovement around angular generated files Change-Id: I784baefaa41db4e45c183335b73e7bb33991070a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125464 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Jaime Wren <jwren@google.com>
Fixes #38344. Change-Id: I64d17fe1e571fc708632c0e48b6556e2094a91e9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125443 Reviewed-by: Samuel Rawlins <srawlins@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
…field's static type. Fix incorrect type arguments when noSuchMethod forwarders allocate Invocation's typeArguments. Change-Id: I0fd2782bc96f500f31dbbdd2aa896c8caf1f0045 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123692 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Reviewed-by: Alexander Aprelev <aam@google.com>
I also added a test for top level late variables (they already worked). Bug: #38841 Change-Id: I6720e6476a067c7f8b21a34b87b23ab14fc866a8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125224 Commit-Queue: Liam Appelbe <liama@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com> Reviewed-by: Régis Crelier <regis@google.com>
Change-Id: I425f81e7e64a02b29e094dab53f37318a09a3c62 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125228 Commit-Queue: Kallen Tu <kallentu@google.com> Reviewed-by: Leaf Petersen <leafp@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Change-Id: Ic5fe4ec2230b233301c628fee8436471a0dbfdb3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125445 Reviewed-by: Mayank Patke <fishythefish@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com>
…llocation and GC. Removes support for accumulators, which now repeat the current live values. Decreases performance difference between release and product modes. Fixes inaccuracy when counters are queried before the first full GC. Golem geomean x64 4.687% Golem geomean arm64 5.770% Bug: #37678 Change-Id: I12b26a9834b0f0f911ddcc6e8e5ff4573272607d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116885 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>
…ests Setting the `enableTimelineLogging` property of `HttpClient` to true results in timeline events being created for HTTP connections and HTTP requests. Timeline events contain general connection information, including: - Request type - Status code - Request / response headers - Cookies - Non-sensitive proxy information - Relevent error messages for failed connections Change-Id: Ibe16a312ab5398c9ae886ea07bea5ca70b63e440 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123540 Commit-Queue: Ben Konyi <bkonyi@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
…low in reload test modes. Change-Id: I60777b0fd3a20b340b12225a24529474eb75b2af Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125483 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
…on it. Runtime functions do not yet implement the NNBD semantics. In a next change, generated code will pass NNBD mode to the runtime. Declare one new VM flags: --strong-non-nullable-type-checks Change-Id: I050a468e4a6b665ce46c345bafba04a947cf7cb0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124105 Commit-Queue: Régis Crelier <regis@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>
Change-Id: I2f89ef54eb4467d23f7507c1217385a1df2d4a11 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124594 Commit-Queue: Kathy Walrath <kathyw@google.com> Reviewed-by: Kathy Walrath <kathyw@google.com>
This relands commits "[cfe] Use StaticTypeContext for getStaticType" 45033c6 "[cfe] Move caching of thisType to CoreTypes" fab25cb "[vm/bytecode] Notify static type context when entering/leaving library" c9f88ae Change-Id: I407d6b0e3b3df503cedc9fcb2c834d835cf083f8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125343 Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Johnni Winther <johnniwinther@google.com>
Change-Id: Ie4d5164759c1d4a8c19e216bfac50b116271f1a1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125342 Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Change-Id: I391b32a5d0753215773b1849c3a953258d3c435e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125490 Reviewed-by: Stephen Adams <sra@google.com> Commit-Queue: Stephen Adams <sra@google.com>
There doesn't appear to be any reason to guard the clearing, and in a future CL it makes sense for it to always be cleared. Change-Id: Id75a0ceb51dff474f20ac5aa5a05e56e49c00698 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125401 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
Change-Id: I82c420bbc2e6d85eef0d602c3993487b78e91f19 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125409 Reviewed-by: Jens Johansen <jensj@google.com>
Change-Id: I4ca0cb419652b4d822d8eb945a77b7243012ed1e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125411 Commit-Queue: Johnni Winther <johnniwinther@google.com> Reviewed-by: Jens Johansen <jensj@google.com>
Change-Id: Ieb92069e08d9a1df8e0692b27086616b4d71e66e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124329 Commit-Queue: Karl Klose <karlklose@google.com> Reviewed-by: William Hesse <whesse@google.com>
This CL enables passing --disassemble to e.g. a product mode gen_snapshot which used to not have the flag even when the disasm. was forcefully included. This CL also: - Fixes numerous typos: marco -> macro. - Reorders the _four_ types of flags in order of strictness. Change-Id: I8e3ef75ea0a748a6af5fa48cf289a57beeb51148 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125404 Commit-Queue: Clement Skau <cskau@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
Change-Id: I4a1ecdb9842f4f189be67e5f5d1b99ddb40d41da Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125202 Reviewed-by: Jens Johansen <jensj@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Johnni Winther <johnniwinther@google.com>
Right now `Script::yield_positions()` is an array mapping function start token positions to arrays. Those arrays contain token positions and are indexed by yield index. => This `Script::yield_positions()` is not available in AOT mode. The fast async stack implementation will need to be able to find out where an async closure was suspended. It does so by looking at the ":await_jump_var", which contains the yield index. It then needs to associate the yield index to token position of the yield. This CL adds an entry into the PcDescriptors for every yield in a async/async* function and removes `Script::yield_positions()`. The entry will associate the yield index with the token position. Flutter gallery total size impact for flutter-release: - armv7: +0.016% - armv8: +0.045% Issue #37668 Change-Id: I0b2ce41e85d8f5d590201bf2fb091578d7379890 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125408 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Clement Skau <cskau@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
Change-Id: Ib3dd188e3b2c65d6e6824487ae7794fe9214bfbb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125264 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
R=brianwilkerson@google.com Change-Id: Ibb26890774a2d79bb098e925a04f16c5fa033340 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126144 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Change-Id: I266701e447e2f7ea0cd432ebb9ab55bddfb5375c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126202 Reviewed-by: Paul Berry <paulberry@google.com>
Fixes the only exception package:typed_data! Change-Id: I130fe63d7e31019ad38a30a681505e88822af443 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126087 Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
The lack of these imports are breaking the `dartdevc_platform` build target when using the `--nnbd` flag. Change-Id: Ib8b8368286c24b5435ad4d141ad68aea8ba6be0a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126220 Auto-Submit: Nicholas Shahan <nshahan@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com> Commit-Queue: Mark Zhou <markzipan@google.com> Reviewed-by: Mark Zhou <markzipan@google.com>
Change-Id: I5235aa38bcde93618a10b88da9ad6a8c3e5dc29c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126141 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
This leaves default link styling for links that aren't click-thru nav, so inside the pop-ups as well as the links to other files at the top of the page. Default styling as in blue and underlined. I also made the code links bold when hovered, because the participant didn't try clicking on them. Hopefully this grabs more attention. Change-Id: Ib35c2353e54faa19ba2fa8e0a613ecabd3298463 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126206 Auto-Submit: Mike Fairhurst <mfairhurst@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Change-Id: Ic204b43221f876c945cc1b973a2165131a3f40b2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125994 Reviewed-by: Nicholas Shahan <nshahan@google.com> Commit-Queue: Mark Zhou <markzipan@google.com>
Change-Id: I2dbf01bbde39029d06aa19fd5c6cd9d80cd3e06b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126241 Commit-Queue: Kathy Walrath <kathyw@google.com> Reviewed-by: Kathy Walrath <kathyw@google.com>
Change-Id: I33132bed9fd950030746adbd8951506a81912c41 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126282 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This is a reland of 3c9e924 Original change's description: > Revamp patch_sdk.dart mainly to use libraries.json. > > This will make it possible to use the script to create a patched sdk > for dart2js and the vm (some followup needed), which will be useful > to migrate their libraries to nnbd. > > In the future, we should be able to leverage this new logic to > write tests that ensure our sdk is warning-free (there are > 80 real > warnings today even on the non-nnbd sdk) > > In detail, this CL includes: > > * loading the libraries data from libraries.json, this removes the need for a > hand-crafted libraries.dart that replicates the data in libraries.json. > > * auto-generates a libraries.dart in the patched sdk that can be used to run > dartanalyzer or to compile an sdk with dartdevc-legacy. > > * script simplifications in patch_sdk.dart > * removed tracking of modification stamps. This didn't appeared to be > used by the ninja rules. I believe it was used to reduce local > iteration cycles when we were first developing the sdk itself. > > * use Uri directly instead of package:path - this simplifies things, > especially since the libraries_specification is Uri-based as well. > > * switch to use package:args for parsing options > > * added an option to merge part files in a single file. I've noticed that the > analyzer provides some false positive errors in part files, but once merged > they are no longer shown. In particular, we are clearly hitting limitations of > dartanalyzer on the patched sdk. At this time the old patch-script generated > an sdk with 1500 warnings, this new script reduces it to 500 (not sure why), > with merging of part files it goes down to 80. > > > Change-Id: I6bbaf92ef4554f00c8bf6b38d19bf79d44fb3e94 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125780 > Reviewed-by: Nicholas Shahan <nshahan@google.com> > Commit-Queue: Sigmund Cherem <sigmund@google.com> Change-Id: Ifcb9dbef36452e41e8e96e086761d76b5a3d988e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125998 Reviewed-by: Nicholas Shahan <nshahan@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com> Auto-Submit: Sigmund Cherem <sigmund@google.com>
Change-Id: I2a5d2034a7887b145393a2231838f4098da36875 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126284 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Change-Id: Ibfa8a254f4918f96dee2a7fe72250766dcbdca65 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126321 Auto-Submit: Johnni Winther <johnniwinther@google.com> Commit-Queue: Karl Klose <karlklose@google.com> Reviewed-by: Karl Klose <karlklose@google.com>
This is done by collecting all frames on the current stack until an async/async* frame is hit
which has yielded before (i.e. is not in sync-async case).
From there on it finds the closure of the async/async* frame and starts traversing the listeners:
while (closure != null) {
yield_index = closure.context[Context::kAsyncJumpVarIndex]
pc = closure.function.code.pc_descriptors.LookupPcFromYieldIndex(yield_index);
<emit pc in frame>
closure = closure.context[Context::kAsyncCompleterVarIndex]._future._resultOrListeners.callback;
}
Bug: #37668
Change-Id: I97030d22e529bf8a74ecd30a8a2589cfe57ad330
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122644
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Excludes pkg/kernel and pkg/front_end/fasta/api_unstable/ Includes pkg/_fe_analyzer_shared Change-Id: Id855c4262dffd3e0fd3b116844af39af68f43987 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126341 Auto-Submit: Johnni Winther <johnniwinther@google.com> Reviewed-by: Clement Skau <cskau@google.com> Commit-Queue: Johnni Winther <johnniwinther@google.com>
Change-Id: Iba19aa26d982e2a89b81c9f9856e560977c26224 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126342 Reviewed-by: Dmitry Stefantsov <dmitryas@google.com> Commit-Queue: Erik Ernst <eernst@google.com>
…ve message while fetching timeline." This reverts commit b3cf5ef. Reason for revert: Breaking timeline view for users in Google3 b/141889413 b/145128403 Original change's description: > [observatory] Properly wait for Catapult's iframe to load. Give message while fetching timeline. > > Change-Id: I342c9315fc31021fb1387bc0e409645cd7a99d6a > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125468 > Reviewed-by: Ben Konyi <bkonyi@google.com> > Commit-Queue: Ryan Macnak <rmacnak@google.com> TBR=bkonyi@google.com,rmacnak@google.com,asiva@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I38b92a5a50955983369f4de7afb577d1a959e724 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126360 Reviewed-by: Ben Konyi <bkonyi@google.com>
Initial import of co19 (nnbd) at 8767031866e8243eafdb46011d4d8a7b5705019d. Roll co19_2 to 368bfa9e877a2df003547f64bb17e30596af10c7: 2019-11-22 irina.arkhipets@gmail.com Issue 501 fixed: correct expected result adjusted. 2019-11-22 irina.arkhipets@gmail.com Issue 501 fixed: correct expected result adjusted. 2019-11-22 irina.arkhipets@gmail.com Issue 499 fixed: correct expected result adjusted. 2019-11-22 sgrekhov@unipro.ru Fixes 500. Expected result corrected 2019-11-12 sgrekhov@unipro.ru Fixes 495. Partial fix. Explicit extension member invocation tests added 2019-11-11 sgrekhov@unipro.ru 495. Partial fix. Null-aware explicit extension member invocation tests added 2019-11-07 sgrekhov@unipro.ru Remove hint in analyzer 2019-11-07 sgrekhov@unipro.ru 495. Partial fix. Explicit extension member invocation tests for composite member invocation added 2019-11-06 sgrekhov@unipro.ru 495. Partial fix. Explicit extension member invocation tests for composite member invocation added 2019-11-05 sgrekhov@unipro.ru 495. Partial fix. Explicit extension member invocation tests for composite member invocation added 2019-10-31 sgrekhov@unipro.ru 495. Partial fix. Explicit extension member invocation tests for binary operations added 2019-10-30 sgrekhov@unipro.ru 495. Partial fix. Explicit extension member invocation tests for binary operations added 2019-10-29 sgrekhov@unipro.ru 495. Partial fix. Explicit extension member invocation tests added 2019-10-10 irina.arkhipets@gmail.com Fixed Issue 494: expected result corrected. 2019-10-09 irina.arkhipets@gmail.com Fixed Issue 493: typo corrected. 2019-10-09 irina.arkhipets@gmail.com Fixed Issue 492: typo corrected. Failures are due to: * Triple-shift is not yet implemented. * #39527 Change-Id: I81578e1e3e18b396f1d20cee7aaa34cd4df54bbf Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125973 Reviewed-by: Jonas Termansen <sortie@google.com>
Change-Id: I6a0dbc67a5c696385e76b1cb340755a573903366 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126281 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
… null Change-Id: I4e0b19b4773e557b8e31583c4ad110ad79a3e426 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126361 Reviewed-by: Danny Tuppeny <dantup@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
This change breaks the dartdevc_platform target for nnbd because it removes the language version comment from only some of the part files in the dart:_js_helper library. At the same time we need to migrate: * annotations.dart * linked_hash_map.dart * identity_hash_map.dart * custom_hash_map.dart * native_helper.dart * regexp_helper.dart * string_helper.dart * js_rti.dart This reverts commit 3e86e8f. Reason for revert: <INSERT REASONING HERE> Original change's description: > [dartdevc] Migrating dart:_js_helper to NNBD. > > Change-Id: Ic204b43221f876c945cc1b973a2165131a3f40b2 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125994 > Reviewed-by: Nicholas Shahan <nshahan@google.com> > Commit-Queue: Mark Zhou <markzipan@google.com> TBR=sigmund@google.com,nshahan@google.com,markzipan@google.com Change-Id: Ie199fd5e93c0eb99cbf1bddc4e8588a325922a61 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126300 Reviewed-by: Mark Zhou <markzipan@google.com> Reviewed-by: Nicholas Shahan <nshahan@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com>
Also add a help option to print the help text it already has. Change-Id: Ifb5036ace762053b52ab7a5170da1bdb37b44ab7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126302 Auto-Submit: Nicholas Shahan <nshahan@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com>
…was disabled. When CPU profiling is disabled, the getCpuSamples RPC would return with a ServerRpcException stating that the profiler was disabled. This wasn't being caught when the RPC was invoked, but was being caught in `ObservatoryApplication` and swallowed. This resulted in the timeline page being stuck at the timeline loading dialog. Also includes fixes from "[observatory] Properly wait for Catapult's iframe to load. Give message while fetching timeline.", commit 3b99524, which was reverted. Change-Id: I2fe23d4dba5e20f717e111c519563866bb1a221c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126402 Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com>
…DartFuzzStats with latest fuzzing run results Change-Id: I3352d27785cabd3052c8db458390277f768dd1c5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126240 Commit-Queue: Ben Konyi <bkonyi@google.com> Reviewed-by: Fizaa Luthra <fizaaluthra@google.com>
This fixes the problem with inferring E? in package:typed_data. Change-Id: I376204e3f82f0d6054a2c78b502fd240db48798d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126362 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
…ionTest. Change-Id: Ic6e0f593213e69c9524eb9e0909ad71f72700b49 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126285 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Change-Id: I5faf799a5e3567f3f95bf65c279d0ac95363e193 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126400 Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
Support for required named parameters. Change-Id: Ic9dd286779ade8f9cceb5231f68b606148b295ff Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126180 Reviewed-by: Mike Fairhurst <mfairhurst@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Remove the language version comment from dart:_js_helper but it has not yet been fully migrated. This only makes the necessary changes to fix errors in dart:core. Change-Id: Ib0dafd7838ad46e5e0284cefb751e12504c318b1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126401 Reviewed-by: Mark Zhou <markzipan@google.com> Commit-Queue: Mark Zhou <markzipan@google.com>
Change-Id: I9f2da85e1c283ed4942ba076c98003aef80b7051 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126203 Reviewed-by: Jaime Wren <jwren@google.com> Reviewed-by: Mike Fairhurst <mfairhurst@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.