add Digamma op #10066
Merged
add Digamma op #10066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youxiudeshouyeren
requested review from
hjchen2,
BBuf,
jackalcooper,
liujuncheng and
daquexian
as code owners
marigoold
reviewed
Apr 3, 2023
youxiudeshouyeren
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
clackhan
reviewed
Apr 7, 2023
Comment on lines
3320
to
3321
|
|
| struct UnaryFunctor<DeviceType::kCPU, UnaryOp::kDigamma, float, float> { | ||
| OF_DEVICE_FUNC UnaryFunctor(Scalar attr0, Scalar attr1) {} | ||
|
|
||
| OF_DEVICE_FUNC float operator()(float src) const { |
There was a problem hiding this comment.
这个实现是参考的什么地方，可以在注释中放个链接吗？
已添加
… into digamma_op_dev
clackhan
approved these changes
Apr 7, 2023
clackhan
reviewed
Apr 7, 2023
Ldpe2G
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
参见 https://pytorch.org/docs/stable/special.html?highlight=digamma#torch.special.digamma
剩余
flow.digamma接口
tensor.digamma接口