-
Notifications
You must be signed in to change notification settings - Fork 468
Metro skin right-hand alignment with Icon Frames #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is the first time I've done a pull request, so I can change anything if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
It will be just great to add explanation why this change was done to commit message. So that it will be clear also in the future.
Basically you can put there the reasoning you provided in PR description.
To edit commit message you should:
git commit --amend
- edit message and save
git push -f
I think the description is fixed now. Let me know if I need to make any other changes. |
I meant to add this explanation: It nicely explains what the change does and why it was done. Subject of commit message (first line) is fine as you did it. |
Just to make sure, that can go in the lines starting with "Please enter the commit message for your changes"? Or can it go anywhere else in the same file? |
This should improve the right-hand spacing when icon frames are enabled, and right-hand icons are disabled. There shouldn't be any extra icon/text padding for Main2 when icons aren't enabled.
Ok, I think I figured it out. |
@bonzibudd |
This should improve the right-hand spacing when icon frames are enabled, and right-hand icons are disabled. There shouldn't be any extra icon/text padding for Main2 when icons aren't enabled.