Skip to content

Conversation

bonzibudd
Copy link
Member

This should improve the right-hand spacing when icon frames are enabled, and right-hand icons are disabled. There shouldn't be any extra icon/text padding for Main2 when icons aren't enabled.

@bonzibudd
Copy link
Member Author

This is the first time I've done a pull request, so I can change anything if needed.

@bonzibudd bonzibudd marked this pull request as draft May 3, 2021 21:10
@bonzibudd bonzibudd marked this pull request as ready for review May 3, 2021 21:10
@AppVeyorBot
Copy link

@bonzibudd bonzibudd marked this pull request as draft May 3, 2021 21:11
@bonzibudd bonzibudd marked this pull request as ready for review May 3, 2021 21:11
ge0rdi
ge0rdi previously approved these changes May 4, 2021
Copy link
Member

@ge0rdi ge0rdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

It will be just great to add explanation why this change was done to commit message. So that it will be clear also in the future.
Basically you can put there the reasoning you provided in PR description.

To edit commit message you should:

  • git commit --amend
  • edit message and save
  • git push -f

@bonzibudd
Copy link
Member Author

I think the description is fixed now. Let me know if I need to make any other changes.

@AppVeyorBot
Copy link

@ge0rdi
Copy link
Member

ge0rdi commented May 4, 2021

I meant to add this explanation:
This should improve the right-hand spacing when icon frames are enabled, and right-hand icons are disabled. There shouldn't be any extra icon/text padding for Main2 when icons aren't enabled.

It nicely explains what the change does and why it was done.

Subject of commit message (first line) is fine as you did it.
You can just add that explanation and that's it.

@bonzibudd
Copy link
Member Author

bonzibudd commented May 4, 2021

Just to make sure, that can go in the lines starting with "Please enter the commit message for your changes"? Or can it go anywhere else in the same file?

This should improve the right-hand spacing when icon frames are enabled, and right-hand icons are disabled. There shouldn't be any extra icon/text padding for Main2 when icons aren't enabled.
@bonzibudd
Copy link
Member Author

Ok, I think I figured it out.

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@ge0rdi ge0rdi merged commit 1db0006 into Open-Shell:master May 4, 2021
@ge0rdi
Copy link
Member

ge0rdi commented May 4, 2021

@bonzibudd
Merged.
Thank you for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants