Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Client] Add support for the new Spring RestClient #18522

Merged
merged 20 commits into from
May 1, 2024

Conversation

Nicklas2751
Copy link
Contributor

@Nicklas2751 Nicklas2751 commented Apr 27, 2024

Created a new Java Client for the Spring 6 RestClient.
This solves #17571

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@wing328
Copy link
Member

wing328 commented May 1, 2024

the CI tests failed. can you please take a look when you've time?

@wing328
Copy link
Member

wing328 commented May 1, 2024

can you please resolve the merge conflicts when you've time?

@Nicklas2751
Copy link
Contributor Author

Nicklas2751 commented May 1, 2024

the CI tests failed. can you please take a look when you've time?

I had to regenerate the sample tests which were missing the @Ignore.
All other java clients I looked at had it disabled too. But for what are these test if their disabled and not runnable?

EDIT:
Found the answer: https://github.com/openapitools/openapi-generator/wiki/How-to-add-a-generator-for-a-new-language-or-framework :)

@Nicklas2751
Copy link
Contributor Author

can you please resolve the merge conflicts when you've time?

sure

@Nicklas2751
Copy link
Contributor Author

Hm, cause of the failing check I re-reun the whole generate-samples script and now I have changes in the go petstore sample 🤔

@wing328
Copy link
Member

wing328 commented May 1, 2024

please ignore those for the time being

@wing328 wing328 added this to the 7.6.0 milestone May 1, 2024
@wing328
Copy link
Member

wing328 commented May 1, 2024

outdated samples already fixed in the master

@wing328 wing328 merged commit ef2fa03 into OpenAPITools:master May 1, 2024
71 of 72 checks passed
@wing328
Copy link
Member

wing328 commented May 1, 2024

@Nicklas2751 thanks for the PR, which has been merged into the master

@AhmedOsama1999
Copy link

AhmedOsama1999 commented May 30, 2024

There is an issue when generateClientAsBean is true the client classes are not annotated with @component like resttemplae library

@Nicklas2751
Copy link
Contributor Author

@AhmedOsama1999 The documentation says the following for generateClientAsBean :

For resttemplate, configure whether to create ApiClient.java and Apis clients as bean (with @component annotation).

So, it's currently a resttemplate only feature.

@Nicklas2751 Nicklas2751 deleted the spring-restclient branch October 10, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants