-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java][Client] Add support for the new Spring RestClient #18522
Conversation
the CI tests failed. can you please take a look when you've time? |
can you please resolve the merge conflicts when you've time? |
I had to regenerate the sample tests which were missing the EDIT: |
sure |
…nt mustache files The RestClient API is oriented on the WebClient API so many parts of the templates can be the same
…plate The README must be changed because the minimal Java Version for this client is 17
The minimum Java version of the used Spring Version is 17
3267921
to
f3cafed
Compare
…en null body is set
Hm, cause of the failing check I re-reun the whole generate-samples script and now I have changes in the go petstore sample 🤔 |
please ignore those for the time being |
Also regenerated the restclient samples
outdated samples already fixed in the master |
@Nicklas2751 thanks for the PR, which has been merged into the master |
There is an issue when generateClientAsBean is true the client classes are not annotated with @component like resttemplae library |
@AhmedOsama1999 The documentation says the following for
So, it's currently a |
Created a new Java Client for the Spring 6 RestClient.
This solves #17571
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)