Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][jaxrs] Add getter to ApiException templates #7150

Merged
merged 1 commit into from
Aug 9, 2020

Conversation

Xendar
Copy link
Contributor

@Xendar Xendar commented Aug 6, 2020

Fixes #6830

Basically a few ApiException templates for Java servers were missing a getter for the code field.
Before the fix the generated class was:

package org.openapitools.api;

@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaResteasyServerCodegen", date = "2020-07-01T16:12:55.083+02:00[Europe/Paris]")
public class ApiException extends Exception{
    private int code;
    public ApiException (int code, String msg) {
        super(msg);
        this.code = code;
    }
}

With the fix it becomes:

package org.openapitools.api;

@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaResteasyServerCodegen", date = "2020-08-06T22:46:58.073+02:00[Europe/Paris]")
public class ApiException extends Exception {

    private int code;

    public ApiException(int code, String msg) {
        super(msg);
        this.code = code;
    }

    public int getCode() {
        return code;
    }

}

Validation

I compiled the cli jar and generated the new class with the same command as in the issue description, then compiled the generated code.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Technical committee: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda

@Xendar Xendar changed the title Bug #3830: Java server - Add getter to ApiException templates Issue #6830: Java server - Add getter to ApiException templates Aug 6, 2020
@Xendar Xendar marked this pull request as draft August 6, 2020 21:02
@Xendar Xendar marked this pull request as ready for review August 6, 2020 21:08
@wing328
Copy link
Member

wing328 commented Aug 7, 2020

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

super(msg);
this.code = code;
}

public int getCode() {
Copy link
Member

@wing328 wing328 Aug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if you can add the proper javadoc as well.

Copy link
Contributor Author

@Xendar Xendar Aug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing!
Let me know if you want me to change the wording :)

@Xendar
Copy link
Contributor Author

Xendar commented Aug 7, 2020

The Circle CI build failed because of a timeout, but I do not have the rights to relaunch it it seems :(

@Xendar Xendar requested a review from wing328 August 7, 2020 16:20
@wing328 wing328 added this to the 5.0.0 milestone Aug 9, 2020
@wing328 wing328 changed the title Issue #6830: Java server - Add getter to ApiException templates Java server - Add getter to ApiException templates Aug 9, 2020
@wing328 wing328 changed the title Java server - Add getter to ApiException templates [Java][jaxrs] Add getter to ApiException templates Aug 9, 2020
@wing328 wing328 merged commit 930c622 into OpenAPITools:master Aug 9, 2020
jimschubert added a commit that referenced this pull request Aug 12, 2020
* master: (27 commits)
  [WIP][python-exp] Force camelization of imports (#7186)
  Fixes #6942: Added ability to prepend a basePath to typescript-redux-query generators (#6943)
  [Typescript] Import path is invalid in windows. (#7175)
  Fix JaxRS Spec generator additional model types (#7180)
  [python{,-experimental}] Obey floating point timeouts provided to RESTClientObject.request(...) (#7154)
  [C#] Switch the spec to OAS v3 from v2 (#7176)
  [Javascript] Fixing the handling of non primitive types in paramToString (#7171) (#7172)
  [typescript-node] Fix invalid type when using node@10 and ES5 (#7133)
  Minor fix to github workflow badge
  [gradle] Enabling up-to-date checks and gradle caching for openapigenerator tasks (#6716)
  feat(csharp-netcore): Adding response headers to the ApiException (#7169)
  [ci] Verify supported JDK versions on master push (#7085)
  Issue #6830: Java server - Add getter to ApiException templates (#7150)
  update kotlin samples
  [Kotlin] Make ApiClient in jvm-retrofit2 be able to use own OkHttpClient (#6999)
  Sttp - wrap query params (#6884)
  Add a link to https://medium.com/@everisBrasil blog post (#7160)
  [C#][netcore] fix regular expression when it contains double quotes (#7147)
  remove duplicated cancellationToken in comment (#7148)
  update samples
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][JAVA] ApiException error code is private without getter
2 participants