Skip to content

Conversation

JakobPetersson
Copy link

After using/reading through the Meade command documentation I have a very small fix.

@anjok
Copy link

anjok commented Mar 21, 2022

You also need to fix the utc offset

@JakobPetersson
Copy link
Author

JakobPetersson commented Mar 21, 2022

You also need to fix the utc offset

I am unsure of what related documentation of UTC offset you mean could be fixed at the same time. Can you clarify?

Edit: I understand which change you mean. But that appears to be an incorrect implementation of the protocol, and should be handled as a separate issue. Unrelated to this small fix.

@ClutchplateDude
Copy link
Member

You also need to fix the utc offset

I am unsure of what related documentation of UTC offset you mean could be fixed at the same time. Can you clarify?

Edit: I understand which change you mean. But that appears to be an incorrect implementation of the protocol, and should be handled as a separate issue. Unrelated to this small fix.

You don't NEED to fix anything, Jakob. Just submit what you feel comfortable with and that helps with the code base.

@JakobPetersson
Copy link
Author

You don't NEED to fix anything, Jakob. Just submit what you feel comfortable with and that helps with the code base.

You don't have to worry @ClutchplateDude :) Thank you for checking in on this PR.

Should we keep the PR going?
Merge it?
Or move these changes into #180?

@JakobPetersson
Copy link
Author

Fixes included in #181, closing.

@JakobPetersson JakobPetersson deleted the fix-meade-command-documentation branch March 27, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants