Skip to content

Conversation

ClutchplateDude
Copy link
Member

  • Corrected Longitude parsing to account for sign
  • Corrected Longitude output to provide sign
  • Corrected inverted UTC offset
  • Corrected handshake response to 0x06 to be P for Polar mode
  • EEPROM debug code caused crash due to using F() macro in args
  • Added specific Longitude output function for Meade
  • Fixed comment on Meade :SC command

- Corrected Longitude parsing to account for sign
- Corrected Longitude output to provide sign
- Corrected inverted UTC offset
- Corrected handshake response to 0x06 to be P for Polar mode
- EEPROM debug code caused crash due to using F() macro in args
- Added specific Longitude output function for Meade
- Fixed comment on Meade :SC command
@openastrotech-bot
Copy link
Contributor

Looks like your PR has code that needs to be changed in order to meet our coding standards!
Here are your options:

  1. Apply the patch that was generated by the job
    1. Click details under the failing clang-format check
    2. Click the Artifacts dropdown in the top right
    3. Download + unzip the clang-format-diff.patch file into the OpenAstroTracker-Firmware repo
    4. Run git apply clang-format-diff.patch to make the changes
    5. Commit and push up the formatted code
  2. Run clang-format locally
    1. Run the command bash -c 'shopt -s nullglob globstar;GLOBIGNORE=./src/libs/TimerInterrupt/*; for i in ./{.,src/**,unit_tests,boards/**}/*.{c,cpp,h,hpp}; do clang-format -i $i; done'
    2. Commit and push up the formatted code

@ClutchplateDude ClutchplateDude merged commit d387d8d into develop Mar 27, 2022
@ClutchplateDude ClutchplateDude deleted the meade-fix branch March 27, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants