A few more Robe PIDs #203
Merged
A few more Robe PIDs #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomis52
approved these changes
Jun 15, 2018
|
I need to work out why this is failing and fix it first... |
|
@vanous would you mind reviewing these before I merge if you've got time? |
|
LGTM |
|
It looks good. Tomas says it's not complete, but i am not sure (when) he can export all the others... i am trying but cannot promise. Perhaps wait a few more days, then merge. |
|
Thanks @vanous . You gave me a load of other PIDs here #100 (comment) which I've formatted into a list in #197 and will tick off as they get merged. I was mostly hoping you could sanity check them and confirm any sub device targeting, or are they all root? And confirm things like DMC, although Googling suggests "During Movement Correction". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.