Add another manufacturer PID

[peternewman]

From the snapshot here:
OpenLightingProject/ola#1275

To be reviewed by @vanous .

[vanous]

Thank you very much @peternewman , i am getting through my mail bag. I have emailed Tomas (our main RDM developer) for full list of our manufacturer specific PIDs, hopefully to have something soon.

cheers

Petr

[peternewman]

That's great thanks @vanous .

In the meantime are you happy with this one, or would you rather I wait until we've got the full list from your developer?

[vanous]

Hi Peter, i have spoken with our dev and he will look at this after his holidays (2wks, starting today). So if this is no blocker, please wait and we merge it together.

[peternewman]

No blocker, I'm just being impatient, but it certainly makes sense to wait until your actual RDM dev is available, that would be perfect.

[vanous]

oh, speak of impatient :) i have been pushing him for this, but he is very good, thus very busy... but once he promises, he usually delivers :)

[vanous]

Hi Peter,

terribly swamped here. Nonetheless, finally, have some PIDs :)
I will try to format them as time permits.

Cheers

Petr

ROBE_PT_FEED 0xa000 Pan/Tilt Feedback 0-off 1-on
ROBE_PT_MODE 0xa001 Pan/Tilt Mode 0-speed 1-time
ROBE_MIC_SENS 0xa002 Microphone sensitivity 1-20
ROBE_THEATRE_MODE 0xa003 Theatre mode 0-off 1-quiet / Theatre m. 0-auto 1-silent 2-off
ROBE_C_CAL_MODE 0xa004 Colour cal. mode 0-off 1-on
ROBE_C_MIX_MODE 0xa005 Colour mixing mode 0-RGB 1-CMY
ROBE_UV_MIXING 0xa006 UV mixing 0-on 1-off
ROBE_WHITE_POINT_8K 0xa007 White point 8000K 0-on 1-off
ROBE_OUTPUT_MODE 0xa008 Output mode 0-CRI 1-intensity
ROBE_OUTPUT_UNIFORMITY 0xa009 Output uniformity 0-off 1-on
ROBE_OUTPUT_CONSISTENCY 0xa00a Output consistency 30-65
ROBE_CRI_SELECTION 0xa00b CRI selection 0-70 ... 4-90+
ROBE_TH_EF_SIM 0xa00c Th. Eff. Sim. 0-off ... 5-2500 W
ROBE_DL_COMPATIBLE_MODE 0xa00d DL compatible mode 0-off 1-on
ROBE_DISPLAY_INTENSITY 0xa00e Display intensity 1-10
ROBE_TOUCHSCREEN_LOCK 0xa00f Touchscreen lock 0-off...10min
ROBE_TEMPERATURE_UNIT 0xa010 Temperature Unit 0-C 1-F
ROBE_FAN_MODE 0xa011 Fan mode 0-auto 1-high 2-silent / Fan mode 0-auto 1-high
ROBE_CMY_CONTROL 0xa012 CMY control 0-fixed 1-mixing
ROBE_DIMMER_CURVE 0xa013 Dimmer curve 0-linear 1-square law
ROBE_BLACKOUT_DMC 0xa014 Blackout DMC 0-off 1-on
ROBE_BLACKOUT_PTM 0xa015 Blackout w. P/T move 0-off 1-on
ROBE_BLACKOUT_GWM 0xa016 Blackout w. Gobo move 0-off 1-on
ROBE_BLACKOUT_COLM 0xa017 Blackout w. Col. move 0-off 1-on
ROBE_BLACKOUT_TIM 0xa018 Timeout Blackout 0-off 1-on
ROBE_EXTEND_SC_FUNC 0xa019
ROBE_STAND_ALONE 0xa01a Stand alone 0-off 1-T 2-U1 3-U2

[peternewman]

Perfect thanks @vanous .

I don't mind doing some of the leg work on the formatting of the PIDs if you'd like? Certainly for the boolean ones, it should be a fairly simple copy and paste job.

Do those PIDs all support get and set? Do any of your bits of kit have subdevices, and if so, can get and set be targeted at root or sub devices for the various PIDs? Do you refer to them as ROBE_ in the manual, we seem to be about 50/50 currently with previous PIDs as to whether they're prefixed with the manufacturer name or not.

Finally what do you want to do about the existing PR? Are you happy with it, shall we merge it?

[vanous]

@peternewman i am waiting for Tomas to reply :)
Other then that i am happy with the PR.

[peternewman]

Hi @vanous ,

Did Tomas ever reply to you? 😄

I'm not quite clear, does "Other then that i am happy with the PR." mean we need his reply to merge this PR? Or was that just regarding the other PIDs?

[vanous]

Hi Peter,

i have missed your email and am very sorry about it. The PIDs are OK, please merge.

Thank you

Petr

[peternewman]

Blocked behind #196 .