Make sure sum isn't reduced just within each team, but across teams too.

[jakubjelinek]

Make the testcases also OpenMP 4.5 compliant by adding map(tofrom: sum),
otherwise sum is firstprivate on target.

[milfeld]

Hi Jakub,
This looks fine. Is there a TRAC ticket for this? If not, I'll create one and have somebody review it. Is there anything special that should be mentioned in the text? Hmm, interesting. In a combined construct, target teams distribute parallel loop, there is only one reduction needed-- that seems obvious, but do we need to mention that in the spec?
Kent

[jakubjelinek]

There is no trac ticket for this, the changes came from a developer reporting issues in the testcases.
In a combined/composite construct that has teams and parallel combined, reduction on such combined constructs applies to both (first combine from each thread, then combine from each team).
But for separate constructs, if you just reduce from each thread, but not from the teams, you have data race (the var is then shared between the teams and each team writes it).

[milfeld]

Hi Jakub,
Thanks for you input on this. We took care of this on the examples-internal repo, so I'm closing it on this repo (examples). Thanks again.
Kent