Allow to copy ACL and config path #2774

luigifab · 2022-12-02T17:27:27Z

Description

A new feature!

Bellow click on the link, and paste the config path where you want!
You can disable it from System > Configuration > Admin > Admin theme (admin/design/copy_path).

Tested with Firefox 108, Chrome 108, Opera 94.
navigator.clipboard.writeText require Firefox 63+, Chrome 66+, Edge 79+, Opera 53+, Safari 13.1+ (mdn docs).

1/ Go to System / Configuration:

before/after

2/ Go to System / Web Services / SOAP Roles, add or edit any role:

before/after

3/ Go to System / Permissions / Roles, add or edit any role:

before/after

Warning

Not complete for System / Web Services / REST Roles, I'm not sure how them works.

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All automated tests passed successfully (all builds are green)
Add yourself to contributors list

sreichel · 2022-12-03T23:07:45Z

I like it, but do we need this in production mode?

Change

Mage::getIsDeveloperMode() || Mage::helper('admin/variable')->isPathAllowed($element->getPath())

to

Mage::getIsDeveloperMode() && Mage::helper('admin/variable')->isPathAllowed($element->getPath())

What do think?

sreichel · 2022-12-04T21:39:14Z

Do we have to adjust openmage-theme (SCSS, CSS) too?

luigifab · 2022-12-08T08:28:33Z

I didn't test with openmage theme.

For production mode, normal admin can use only isPathAllowed in cms blocks, cms pages, wysiwyg products and categories attributes, transactional emails. In dev mode, developers can use all path in PHP files.

kyrena · 2022-12-23T11:47:01Z

There was a module for Magento 1.4-9? that add a red icon (for default configuration) when configuration is modified by store view. Is someone know where I can find it?

sreichel · 2022-12-23T17:31:33Z

There was a module for Magento 1.4-9? that add a red icon (for default configuration) when configuration is modified by store view. Is someone know where I can find it?

I know that extension, but cant find it (was it a hackathon project?) There is a similar one: https://github.com/ericthehacker/magento-configscopehints (and https://github.com/avstudnitz/AvS_ScopeHint).

Flyingmana · 2022-12-25T00:07:41Z

good idea.
Can we put it behind a config value? Iam worried not everyone might like the potentially long extra text.
also please change it to the branch for a later version (its a new feature)
And I wonder if we should make it more flexible, but thats something for a later iteration

sreichel · 2022-12-27T06:13:33Z

good idea.

we could also use an icin instead of text
duplicated js code javascript:navigator.clipboard.writeText could move to core/js helper
replace inline style style="font-style:italic with css

luigifab · 2023-01-05T14:31:16Z

I think that I have added all comments to the PR (except the red icon). It's not necessary to update openmage theme.
Do I need to change the branch to 20?

sreichel · 2023-01-05T20:42:44Z

Think v19 is correct. Will test it later.

luigifab · 2023-11-12T17:40:55Z

Yes? No? To know if I try to add the red mark or not.

kiatng · 2023-11-13T04:00:52Z

So I installed this PR:

But I don't see effects:

Any idea what I miss.

[edit] OOOPs, only for developer mode.

kiatng · 2023-11-13T04:08:18Z

app/code/core/Mage/Core/etc/system.xml

+                        <copy_path translate="label">
+                            <label>Allow to copy/paste roles and configuration path</label>
+                            <frontend_type>select</frontend_type>
+                            <source_model>adminhtml/system_config_source_yesno</source_model>


Instead of yes/no:

Only in Developer Mode (default)

Yes

No

app/code/core/Mage/Core/etc/system.xml

fballiano · 2024-04-01T05:06:41Z

why is this feature behind "developer mode"? I don't see why normal admin shouldn't be able to copy ACLs from a role to another no?

luigifab · 2024-04-09T16:44:04Z

When you are a normal admin user, you can use only allowed config path in email, cms and pages, so this PR display copy links only for allowed config paths.

But it's true that if you are a normal admin user with access to all admin features, you can add any config paths to allowed list.

This PR display all copy links only in dev mode because I supposed that there are useless when you are using the backend as a normal user, not as a dev user.

empiricompany · 2024-04-30T09:02:50Z

I've checked out the PR, but the new feature doesn't show up in every section of system/config and in permissions.
Also, when clicking, the path is not copied (Firefox)

if i click on config nothing is copied

Nothing appears here:

I've disabled all caches and also re-logged in to the backend

fballiano · 2024-04-30T20:15:09Z

I think #3960 will be merged before this one and this one will have to be slightly adjusted, for example using the copy icon and the js functions ;-)

kiatng · 2024-06-05T05:12:24Z

app/code/core/Mage/Adminhtml/Block/Api/Tab/Rolesedit.php

@@ -77,6 +77,10 @@ protected function _getNodeJson($node, $level = 0)
            $item['sort_order'] = isset($node->sort_order) ? (string)$node->sort_order : 0;
            $item['id']  = (string)$node->attributes()->aclpath;

+            if (Mage::getIsDeveloperMode() && Mage::getStoreConfigFlag('admin/design/copy_path')) {
+                $item['text'] .= '</a> <a href="javascript:copyText(\'' . $item['id'] . '\');" class="copycnf">(' . $item['id'] . ')';


Function name conflict, see PR #3960

kiatng · 2024-06-05T05:12:45Z

js/mage/adminhtml/tools.js

@@ -11,6 +11,11 @@
 * @copyright   Copyright (c) 2019-2023 The OpenMage Contributors (https://www.openmage.org)
 * @license     https://opensource.org/licenses/afl-3.0.php  Academic Free License (AFL 3.0)
 */
+
+function copyText(txt) {


Function name conflict, see PR #3960

kiatng · 2024-06-05T05:15:10Z

I agree with @fballiano, this PR needs to incorporate what was done in PR #3960.

luigifab · 2024-06-05T14:09:30Z

Yes, but I can't do it for now.

github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 labels Dec 2, 2022

luigifab added the new feature label Dec 2, 2022

github-actions bot added the Template : admin Relates to admin template label Dec 3, 2022

github-actions bot added the Component: PayPal Relates to Mage_Paypal label Dec 8, 2022

github-actions bot added Component: Core Relates to Mage_Core documentation JavaScript Relates to js/* translations Relates to app/locale labels Jan 1, 2023

luigifab marked this pull request as ready for review January 1, 2023 13:00

Allow to copy ACL and config path

7a57b79

luigifab changed the base branch from 1.9.4.x to main April 9, 2023 08:21

addison74 self-assigned this Jul 14, 2023

luigifab added the help wanted label Oct 21, 2023

Merge branch 'main' into copy-path

df1ecbc

kiatng reviewed Nov 13, 2023

View reviewed changes

app/code/core/Mage/Core/etc/system.xml Outdated Show resolved Hide resolved

Updated label

9a1814c

luigifab mentioned this pull request Apr 24, 2024

In backend, add "click to copy text" feature #3952

Closed

Merge branch 'main' into copy-path

2c10ebe

Merge branch 'main' into copy-path

8fabaaa

kiatng reviewed Jun 5, 2024

View reviewed changes

luigifab marked this pull request as draft July 17, 2024 09:44

luigifab closed this by deleting the head repository Jul 29, 2024

addison74 added the Don't forget this PR label Aug 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow to copy ACL and config path #2774

Allow to copy ACL and config path #2774

luigifab commented Dec 2, 2022 •

edited

Loading

sreichel commented Dec 3, 2022

sreichel commented Dec 4, 2022

luigifab commented Dec 8, 2022 •

edited

Loading

kyrena commented Dec 23, 2022 •

edited

Loading

sreichel commented Dec 23, 2022 •

edited by luigifab

Loading

Flyingmana commented Dec 25, 2022

sreichel commented Dec 27, 2022 •

edited

Loading

luigifab commented Jan 5, 2023

sreichel commented Jan 5, 2023

luigifab commented Nov 12, 2023

kiatng commented Nov 13, 2023 •

edited

Loading

kiatng Nov 13, 2023 •

edited

Loading

fballiano commented Apr 1, 2024

luigifab commented Apr 9, 2024

empiricompany commented Apr 30, 2024

fballiano commented Apr 30, 2024

kiatng Jun 5, 2024

kiatng Jun 5, 2024

kiatng commented Jun 5, 2024

luigifab commented Jun 5, 2024

Allow to copy ACL and config path #2774

Allow to copy ACL and config path #2774

Conversation

luigifab commented Dec 2, 2022 • edited Loading

Description

Warning

Contribution checklist

sreichel commented Dec 3, 2022

sreichel commented Dec 4, 2022

luigifab commented Dec 8, 2022 • edited Loading

kyrena commented Dec 23, 2022 • edited Loading

sreichel commented Dec 23, 2022 • edited by luigifab Loading

Flyingmana commented Dec 25, 2022

sreichel commented Dec 27, 2022 • edited Loading

luigifab commented Jan 5, 2023

sreichel commented Jan 5, 2023

luigifab commented Nov 12, 2023

kiatng commented Nov 13, 2023 • edited Loading

kiatng Nov 13, 2023 • edited Loading

Choose a reason for hiding this comment

fballiano commented Apr 1, 2024

luigifab commented Apr 9, 2024

empiricompany commented Apr 30, 2024

fballiano commented Apr 30, 2024

kiatng Jun 5, 2024

Choose a reason for hiding this comment

kiatng Jun 5, 2024

Choose a reason for hiding this comment

kiatng commented Jun 5, 2024

luigifab commented Jun 5, 2024

luigifab commented Dec 2, 2022 •

edited

Loading

luigifab commented Dec 8, 2022 •

edited

Loading

kyrena commented Dec 23, 2022 •

edited

Loading

sreichel commented Dec 23, 2022 •

edited by luigifab

Loading

sreichel commented Dec 27, 2022 •

edited

Loading

kiatng commented Nov 13, 2023 •

edited

Loading

kiatng Nov 13, 2023 •

edited

Loading