Notify about constant values in match inputs.

Belonging to [master]:
  - #2277
  - OpenModelica/OpenModelica-testsuite#876

Author: perost

3rdParty

@@ -7931,13 +7931,15 @@ algorithm
       list<DAE.Exp> ae;
       list<list<DAE.Exp>> matrix;
 
-    case (DAE.ICONST()) then true;
-    case (DAE.RCONST()) then true;
-    case (DAE.BCONST()) then true;
-    case (DAE.SCONST()) then true;
-    case (DAE.ENUM_LITERAL()) then true;
-    case (DAE.ARRAY(array = ae)) then isConstValueWorkList(ae);
-    case (DAE.MATRIX(matrix = matrix)) then isConstValueWorkListList(matrix);
+    case DAE.ICONST() then true;
+    case DAE.RCONST() then true;
+    case DAE.BCONST() then true;
+    case DAE.SCONST() then true;
+    case DAE.ENUM_LITERAL() then true;
+    case DAE.ARRAY(array = ae) then isConstValueWorkList(ae);
+    case DAE.MATRIX(matrix = matrix) then isConstValueWorkListList(matrix);
+    case DAE.RECORD() then true;
+    case DAE.METARECORDCALL() then true;
     else false;
 
   end match;

Compiler/FrontEnd/Expression.mo

@@ -782,6 +782,7 @@ algorithm
         (matchDecls,ht) = filterUnusedDecls(matchDecls,ht,{},HashTableStringToPath.emptyHashTableSized(hashSize));
         (elabExps,inputAliases,elabCases) = filterUnusedPatterns(elabExps,inputAliases,elabCases) "filterUnusedPatterns() again to filter out the last parts.";
         (elabMatchTy, elabCases) = optimizeMatchToSwitch(matchTy,elabCases,info);
+        checkConstantMatchInputs(elabExps, info);
         exp = DAE.MATCHEXPRESSION(elabMatchTy,elabExps,inputAliases,matchDecls,elabCases,et);
       then (cache,exp,prop);
     else
@@ -793,6 +794,17 @@ algorithm
   end matchcontinue;
 end elabMatchExpression;
 
+protected function checkConstantMatchInputs
+  input list<DAE.Exp> inputs;
+  input SourceInfo info;
+algorithm
+  for i in inputs loop
+    if Expression.isConstValue(i) then
+      Error.addSourceMessage(Error.META_MATCH_CONSTANT, {ExpressionDump.printExpStr(i)}, info);
+    end if;
+  end for;
+end checkConstantMatchInputs;
+
 protected function optimizeMatchToSwitch
   "match str case 'str1' ... case 'str2' case 'str3' => switch hash(str)...
   match ut case UT1 ... case UT2 ... case UT3 => switch valueConstructor(ut)...

Compiler/FrontEnd/Patternm.mo

@@ -1044,6 +1044,9 @@ public constant Message UNIONTYPE_WRONG_NUM_TYPEVARS = MESSAGE(5045, TRANSLATION
   Util.gettext("Uniontype %s has %s type variables, but got %s."));
 public constant Message SERIALIZED_SIZE = MESSAGE(5046, TRANSLATION(), NOTIFICATION(),
   Util.gettext("%s uses %s of memory (%s without GC overhead; %s is consumed by not performing String sharing)."));
+public constant Message META_MATCH_CONSTANT = MESSAGE(5047, TRANSLATION(), NOTIFICATION(),
+  Util.gettext("Match input %s is a constant value."));
+
 
 public constant Message COMPILER_ERROR = MESSAGE(5999, TRANSLATION(), ERROR(),
   Util.notrans("%s"));