Don't fail on invalid each usage in getModelInstance (#11493)

Author: perost

OMCompiler/Compiler/NFFrontEnd/NFTypeCheck.mo

@@ -2862,7 +2862,10 @@ algorithm
         if not isValidAssignmentMatch(ty_match) then
           binding.bindingExp := Expression.expandSplitIndices(exp);
           printBindingTypeError(name, binding, comp_ty, bind_ty, component, context);
-          fail();
+
+          if not InstContext.inInstanceAPI(context) then
+            fail();
+          end if;
         elseif isCastMatch(ty_match) then
           binding := Binding.TYPED_BINDING(exp, ty, binding.variability, binding.eachType,
             binding.evalState, binding.isFlattened, binding.source, binding.info);

testsuite/openmodelica/instance-API/GetModelInstanceBinding7.mos

@@ -25,6 +25,9 @@ getErrorString();
 //       \"name\": \"x\",
 //       \"type\": \"Real\",
 //       \"modifiers\": \"\\\"s\\\"\",
+//       \"value\": {
+//         \"binding\": \"s\"
+//       },
 //       \"prefixes\": {
 //         \"variability\": \"parameter\"
 //       }
@@ -38,5 +41,6 @@ getErrorString();
 //     \"columnEnd\": 8
 //   }
 // }"
-// ""
+// "[<interactive>:3:5-3:27:writable] Error: Type mismatch in binding x = \"s\", expected subtype of Real, got type String.
+// "
 // endResult

testsuite/openmodelica/instance-API/GetModelInstanceBinding8.mos

@@ -0,0 +1,107 @@
+// name: GetModelInstanceBinding8
+// keywords:
+// status: correct
+// cflags: -d=newInst
+//
+//
+
+loadString("
+  model A
+    Real x;
+  end A;
+
+  model M
+    A a1[3](x = 1.0);
+    A a2(each x = 1.0);
+  end M;
+");
+
+getModelInstance(M, prettyPrint = true);
+getErrorString();
+
+// Result:
+// true
+// "{
+//   \"name\": \"M\",
+//   \"restriction\": \"model\",
+//   \"elements\": [
+//     {
+//       \"$kind\": \"component\",
+//       \"name\": \"a1\",
+//       \"type\": {
+//         \"name\": \"A\",
+//         \"restriction\": \"model\",
+//         \"elements\": [
+//           {
+//             \"$kind\": \"component\",
+//             \"name\": \"x\",
+//             \"type\": \"Real\",
+//             \"value\": {
+//               \"binding\": 1
+//             }
+//           }
+//         ],
+//         \"source\": {
+//           \"filename\": \"<interactive>\",
+//           \"lineStart\": 2,
+//           \"columnStart\": 3,
+//           \"lineEnd\": 4,
+//           \"columnEnd\": 8
+//         }
+//       },
+//       \"dims\": {
+//         \"absyn\": [
+//           \"3\"
+//         ],
+//         \"typed\": [
+//           \"3\"
+//         ]
+//       },
+//       \"modifiers\": {
+//         \"x\": \"1.0\"
+//       }
+//     },
+//     {
+//       \"$kind\": \"component\",
+//       \"name\": \"a2\",
+//       \"type\": {
+//         \"name\": \"A\",
+//         \"restriction\": \"model\",
+//         \"elements\": [
+//           {
+//             \"$kind\": \"component\",
+//             \"name\": \"x\",
+//             \"type\": \"Real\",
+//             \"value\": {
+//               \"binding\": 1
+//             }
+//           }
+//         ],
+//         \"source\": {
+//           \"filename\": \"<interactive>\",
+//           \"lineStart\": 2,
+//           \"columnStart\": 3,
+//           \"lineEnd\": 4,
+//           \"columnEnd\": 8
+//         }
+//       },
+//       \"modifiers\": {
+//         \"x\": {
+//           \"each\": true,
+//           \"$value\": \"1.0\"
+//         }
+//       }
+//     }
+//   ],
+//   \"source\": {
+//     \"filename\": \"<interactive>\",
+//     \"lineStart\": 6,
+//     \"columnStart\": 3,
+//     \"lineEnd\": 9,
+//     \"columnEnd\": 8
+//   }
+// }"
+// "[<interactive>:7:13-7:20:writable] Notification: From here:
+// [<interactive>:3:5-3:11:writable] Error: Non-array modification '1.0' for array component 'x', possibly due to missing 'each'.
+// "
+// endResult

testsuite/openmodelica/instance-API/Makefile

@@ -20,6 +20,7 @@ GetModelInstanceBinding4.mos \
 GetModelInstanceBinding5.mos \
 GetModelInstanceBinding6.mos \
 GetModelInstanceBinding7.mos \
+GetModelInstanceBinding8.mos \
 GetModelInstanceBreak1.mos \
 GetModelInstanceChoices1.mos \
 GetModelInstanceChoices2.mos \