Skip to content

Commit bb03c01

Browse files
authored
[NB] Treat all tearing as minimal for now (#14529)
1 parent ce64bf1 commit bb03c01

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

OMCompiler/Compiler/NBackEnd/Modules/3_Post/NBTearing.mo

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -246,10 +246,9 @@ public
246246
String flag = Flags.getConfigString(Flags.TEARING_METHOD);
247247
algorithm
248248
funcs := match flag
249-
case "cellier" then {function initialize(minimal = false), minimal, finalize};
250-
case "noTearing" then {function initialize(minimal = true), minimal, finalize};
251-
case "omcTearing" then {function initialize(minimal = false), minimal, finalize};
252249
case "minimalTearing" then {function initialize(minimal = true), minimal, finalize};
250+
case "cellier" then {function initialize(minimal = true), minimal, finalize}; // TODO set `minimal = false` when it's actually doing something
251+
case "omcTearing" then {function initialize(minimal = true), minimal, finalize}; // TODO set `minimal = false` when it's actually doing something
253252
/* ... New tearing modules have to be added here */
254253
else fail();
255254
end match;
@@ -384,10 +383,6 @@ protected
384383
end match;
385384
end finalize;
386385

387-
function none extends Module.tearingInterface;
388-
// does nothing
389-
end none;
390-
391386
function minimal extends Module.tearingInterface;
392387
// only extracts discrete variables to be solved as inner equations
393388
protected
@@ -434,7 +429,7 @@ protected
434429
adj := Adjacency.Matrix.fromFull(full, v, e, equations, NBAdjacency.MatrixStrictness.MATCHING);
435430
matching := Matching.regular(NBMatching.EMPTY_MATCHING, adj, true, true);
436431
adj := Adjacency.Matrix.upgrade(adj, full, v, e, equations, NBAdjacency.MatrixStrictness.SORTING);
437-
inner_comps := Sorting.tarjan(adj, matching, variables, equations); //probably need other variables and equations here?
432+
inner_comps := Sorting.tarjan(adj, matching, variables, equations); // probably need other variables and equations here?
438433
strict.innerEquations := listArray(inner_comps);
439434

440435
// create residuals equations and iteration variables

0 commit comments

Comments
 (0)