[janitor] Replace listLength == 0 by listEmpty (#12884)

Author: phannebohm

OMCompiler/Compiler/BackEnd/SynchronousFeatures.mo

@@ -133,7 +133,7 @@ algorithm
   if not listEmpty(systs) then
     BackendDAE.DAE({syst}, shared) := BackendDAEOptimize.collapseIndependentBlocks(BackendDAE.DAE(systs, shared));
     (systs, clockedSysts1, unpartRemEqs) := baseClockPartitioning(syst, shared);
-    assert(listLength(clockedSysts1) == 0, "Get clocked system in SynchronousFeatures.addContVarsEqs");
+    assert(listEmpty(clockedSysts1), "Get clocked system in SynchronousFeatures.addContVarsEqs");
     shared.removedEqs := BackendEquation.addList(unpartRemEqs, shared.removedEqs);
   end if;
 

OMCompiler/Compiler/FrontEnd/StateMachineFlatten.mo

@@ -194,7 +194,7 @@ algorithm
   (transitionLst, otherLst2) := List.extractOnTrue(otherLst1, isTransition);
   ({initialStateOp}, otherLst3) := List.extractOnTrue(otherLst2, isInitialState);
   (eqnLst, otherLst4) := List.extractOnTrue(otherLst3, isEquation);
-  assert(listLength(otherLst4) == 0, "Internal compiler error. Unexpected elements in flat state machine.");
+  assert(listEmpty(otherLst4), "Internal compiler error. Unexpected elements in flat state machine.");
 
   DAE.NORETCALL(exp=DAE.CALL(path=Absyn.IDENT("initialState"), expLst={DAE.CREF(componentRef=crefInitialState)})) := initialStateOp;
   ({initialStateComp}, smCompsLst2) := List.extract1OnTrue(smCompsLst, sMCompEqualsRef, crefInitialState);

OMCompiler/Compiler/NBackEnd/Classes/NBEquation.mo

@@ -2881,7 +2881,7 @@ public
         case SOME(b as WHEN_EQUATION_BODY(condition = condition as Expression.ARRAY())) algorithm
           b.else_when := simplify(b.else_when);
           conditions := list(elem for elem guard(not Expression.isFalse(elem)) in arrayList(condition.elements));
-          if listLength(conditions) == 0 then
+          if listEmpty(conditions) then
             body := b.else_when;
           elseif listLength(conditions) == 1 then
             b.condition := listHead(conditions);

OMCompiler/Compiler/NBackEnd/Modules/1_Main/NBResolveSingularities.mo

@@ -220,7 +220,7 @@ public
       // --------------------------------------------------------
       // for both static and dynamic state selection all matched states are regarded dummys
       for dummy in dummy_states loop
-        if listLength(dummy.indices) == 0 then
+        if listEmpty(dummy.indices) then
           dummy_derivatives := BVariable.makeDummyState(Slice.getT(dummy)) :: dummy_derivatives;
         else
           Error.addMessage(Error.INTERNAL_ERROR,{getInstanceName() + " failed because slicing during index reduction is not yet supported.\n"

OMCompiler/Compiler/NBackEnd/Modules/2_Pre/NBAlias.mo

@@ -857,11 +857,11 @@ protected
     Real max_val;
   algorithm
     (constants, rest) := List.splitOnTrue(lst_values, Expression.isConstNumber);
-    if listLength(constants) <> 0 then
+    if not listEmpty(constants) then
       max_val := List.maxElement(list(Expression.realValue(val) for val in constants), realLt);
       rest := Expression.REAL(max_val) :: rest;
     end if;
-    if listLength(rest) == 0 then // constants and rest are empty
+    if listEmpty(rest) then // constants and rest are empty
       max_exp := NONE();
     elseif listLength(rest) == 1 then // one constant or one rest
       max_exp := SOME(List.first(rest));
@@ -886,11 +886,11 @@ protected
     Real min_val;
   algorithm
     (constants, rest) := List.splitOnTrue(lst_values, Expression.isConstNumber);
-    if listLength(constants) <> 0 then
+    if not listEmpty(constants) then
       min_val := List.minElement(list(Expression.realValue(val) for val in constants), realLt);
       rest := Expression.REAL(min_val) :: rest;
     end if;
-    if listLength(rest) == 0 then // constants and rest are empty
+    if listEmpty(rest) then // constants and rest are empty
       min_exp := NONE();
     elseif listLength(rest) == 1 then // one constant or one rest
       min_exp := SOME(List.first(rest));
@@ -1099,7 +1099,7 @@ protected
     StateSelect sval, state_select = StateSelect.NEVER;
     ComponentRef compref, cref;
   algorithm
-    if listLength(lst_values) == 0 then
+    if listEmpty(lst_values) then
       chosen_val := NONE();
       chosen_cref := NONE();
     elseif listLength(lst_values) == 1 then
@@ -1127,7 +1127,7 @@ protected
     list<TearingSelect> lst_values = UnorderedMap.valueList(map);
     TearingSelect tearing_select;
   algorithm
-    if listLength(lst_values) == 0 then
+    if listEmpty(lst_values) then
       chosen_val := NONE();
     elseif listLength(lst_values) == 1 then
       chosen_val := SOME(List.first(lst_values));

OMCompiler/Compiler/NBackEnd/Modules/3_Post/NBSolve.mo

@@ -789,7 +789,7 @@ protected
         (var_cref, solve_status) := getVarSlice(BVariable.getVarName(Util.getOption(record_parent)), eqn);
       else
         // todo: choose best slice of list if more than one.
-        // only fail for listLength == 0
+        // only fail for listEmpty
         solve_status := Status.UNSOLVABLE;
       end if;
     end if;