- Logger of Cpp runtime is now enabled by default, the standard log level was reduced to "warning"

- Kinsol will no continue solving non linear equation systems if the convergence criteria was not reached -> a warning is printed instead until we have a solver that is able to solve the systems correctly

Author: Marcus Walther

Compiler/Template/CodegenCpp.tpl

@@ -2295,7 +2295,7 @@ case SIMCODE(modelInfo=MODELINFO(__), makefileParams=MAKEFILE_PARAMS(__), simula
       try
       {
             Logger::initialize();
-            Logger::setEnabled(false);
+            Logger::setEnabled(true);
             <%if boolNot(stringEq(getConfigString(PROFILING_LEVEL),"none")) then
                 <<
                 std::vector<MeasureTimeData> measureTimeArraySimulation = std::vector<MeasureTimeData>(2); //0 all, 1 setup

SimulationRuntime/cpp/Core/System/ContinuousEvents.cpp

@@ -67,7 +67,7 @@ bool ContinuousEvents::startEventIteration(bool& state_vars_reinitialized)
   _event_system->getConditions(_conditions1);
   bool crestart = !std::equal (_conditions1, _conditions1+dim,_conditions0);
 
-  return((drestart||crestart)); //returns true if new events occured
+  return((drestart||crestart)); //returns true if new events occurred
 }
 /** @} */ // end of coreSystem
 /*

SimulationRuntime/cpp/Include/Core/SimulationSettings/IGlobalSettings.h

@@ -35,7 +35,7 @@ struct LogSettings
 
 	LogSettings()
 	{
-		modes = std::vector<LogLevel>(8,LL_ERROR);
+		modes = std::vector<LogLevel>(8,LL_WARNING);
 	}
 
 	void setAll(LogLevel l)

SimulationRuntime/cpp/Include/Solver/Kinsol/Kinsol.h

@@ -97,7 +97,8 @@ class Kinsol : public IAlgLoopSolver
 
   bool
     _eventRetry,
-    _fValid;
+    _fValid,
+    _solverErrorNotificationGiven;
 
   realtype _fnorm,
     _currentIterateNorm;

SimulationRuntime/cpp/Solver/Kinsol/Kinsol.cpp

@@ -65,6 +65,8 @@ Kinsol::Kinsol(IAlgLoop* algLoop, INonLinSolverSettings* settings)
 	, _Kin_fScale         (NULL)
 	, _kinMem             (NULL)
 	, _scale			  (NULL)
+  , _fValid(false)
+  , _solverErrorNotificationGiven(false)
 {
 	_data = ((void*)this);
 }
@@ -396,7 +398,12 @@ void Kinsol::solve()
 		}
 		*/
 		if(_iterationStatus == SOLVERERROR && !_eventRetry)
-			throw ModelicaSimulationError(ALGLOOP_SOLVER,"Nonlinear solver failed!");
+		  if(!_solverErrorNotificationGiven)
+		  {
+		    Logger::write("Kinsol: Solver error detected. The simulation will continue, but the results may be incorrect.",LC_NLS,LL_WARNING);
+		    _solverErrorNotificationGiven = true;
+		  }
+		//	throw ModelicaSimulationError(ALGLOOP_SOLVER,"Nonlinear solver failed!");
 
 	}
 }