Construct the qualified path of variable (#14341) (#14342)

adeas31 · web-flow · commit f3be2c051ce8 · 2025-09-11T13:34:32.000+02:00
Fixes #14339 Avoid double delete
diff --git a/OMEdit/OMEditLIB/Plotting/VariablesWidget.cpp b/OMEdit/OMEditLIB/Plotting/VariablesWidget.cpp
@@ -101,8 +101,6 @@ VariablesTreeItem::~VariablesTreeItem()
 {
   qDeleteAll(mChildren);
   mChildren.clear();
-  qDeleteAll(mChildrenHash);
-  mChildrenHash.clear();
 }
 
 /*!
@@ -196,8 +194,6 @@ void VariablesTreeItem::removeChildren()
 {
   qDeleteAll(mChildren);
   mChildren.clear();
-  qDeleteAll(mChildrenHash);
-  mChildrenHash.clear();
 }
 
 void VariablesTreeItem::removeChild(VariablesTreeItem *pVariablesTreeItem)
@@ -859,7 +855,7 @@ bool VariablesTreeModel::insertVariablesItems(QString fileName, QString filePath
         if (parentVariable.isEmpty()) {
           findVariable = fileName % "." % variable;
         } else {
-          findVariable = fileName % parentVariable % variable;
+          findVariable = fileName % "." % parentVariable % "." % variable;
         }
       }
       // if its the last item then don't try to find the item as we will always fail to find it

Original file line number	Diff line number	Diff line change
`@@ -101,8 +101,6 @@ VariablesTreeItem::~VariablesTreeItem()`
`101`	`101`	`{`
`102`	`102`	`qDeleteAll(mChildren);`
`103`	`103`	`mChildren.clear();`
`104`		`- qDeleteAll(mChildrenHash);`
`105`		`- mChildrenHash.clear();`
`106`	`104`	`}`
`107`	`105`
`108`	`106`	`/*!`
`@@ -196,8 +194,6 @@ void VariablesTreeItem::removeChildren()`
`196`	`194`	`{`
`197`	`195`	`qDeleteAll(mChildren);`
`198`	`196`	`mChildren.clear();`
`199`		`- qDeleteAll(mChildrenHash);`
`200`		`- mChildrenHash.clear();`
`201`	`197`	`}`
`202`	`198`
`203`	`199`	`void VariablesTreeItem::removeChild(VariablesTreeItem *pVariablesTreeItem)`
`@@ -859,7 +855,7 @@ bool VariablesTreeModel::insertVariablesItems(QString fileName, QString filePath`
`859`	`855`	`if (parentVariable.isEmpty()) {`
`860`	`856`	`findVariable = fileName % "." % variable;`
`861`	`857`	`} else {`
`862`		`- findVariable = fileName % parentVariable % variable;`
	`858`	`+ findVariable = fileName % "." % parentVariable % "." % variable;`
`863`	`859`	`}`
`864`	`860`	`}`
`865`	`861`	`// if its the last item then don't try to find the item as we will always fail to find it`