Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B #3597: Fix send credentials noVNC #3612

Closed
wants to merge 1 commit into from
Closed

B #3597: Fix send credentials noVNC #3612

wants to merge 1 commit into from

Conversation

tryfunc
Copy link

@tryfunc tryfunc commented Aug 23, 2019

Fixed sending noVNC credentials with password enabled.

Signed-off-by: Vadim Chernyshev <tryfunc@gmail.com>
@tryfunc
Copy link
Author

tryfunc commented Sep 7, 2019

@jloboescalona2 Why make a separate PR for the same changes? PR #3651

In addition, to add additional parameters in the future, it would be more logical to do otherwise:

var rfbConfig = password? { "credentials": { "password": password } } : {};
var rfbConfig = { "credentials": { "password": password || null } };

credentials - An Object specifying the credentials to provide to the server when authenticating. The following credentials are possible:

name type description
"username" DOMString The user that authenticates
"password" DOMString Password for the user
"target" DOMString Target machine or session

@jloboescalona2
Copy link
Contributor

hi, @tryfunc. Sorry for the inconvenience, but in your PR not valid, the case that does not send password, in that case the RFB configuration should remain the same call to NoVNV, thanks for your contribution

@tryfunc tryfunc deleted the b-3597 branch October 6, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants