Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrub playernames etc to prevent them breaking the LobbyInfo yaml #3332

Closed
chrisforbes opened this issue May 25, 2013 · 5 comments · Fixed by #8137
Closed

Scrub playernames etc to prevent them breaking the LobbyInfo yaml #3332

chrisforbes opened this issue May 25, 2013 · 5 comments · Fixed by #8137
Labels
Polish

Comments

@chrisforbes
Copy link
Member

Currently you can cause all kinds of fun misbehavior.
@Mailaender
Copy link
Member

See also #3200.

@Mailaender
Copy link
Member

Which characters cause misbehavior?

@chrisforbes
Copy link
Member Author

Newline is the obvious one. You can fake arbitrary chunks of lobbyinfo with
newline/tab/tab/...

On Wed, Jun 19, 2013 at 6:58 AM, Matthias Mailänder <
notifications@github.com> wrote:

Which characters cause misbehavior?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/3332#issuecomment-19632956
.

@ScottNZ
Copy link
Contributor

ScottNZ commented Jul 3, 2013

Somewhat related: you can use a nbsp as a player name to cause all kinds of fun breakage and crashes.

@Mailaender Mailaender mentioned this issue Aug 6, 2013
Open
@ihptru
Copy link
Contributor

ihptru commented Sep 15, 2013

http://i.imgur.com/x9K00dQ.png

@Mailaender Mailaender mentioned this issue Mar 7, 2015
Closed
@Mailaender Mailaender mentioned this issue Apr 26, 2015
Closed
@Mailaender Mailaender mentioned this issue May 10, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Polish
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added a client side player name sanitation Mailaender/OpenRA
4 participants
@chrisforbes @Mailaender @ihptru @ScottNZ