Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename FlyCircle to FlyIdle and make it tick TickIdle #16797

Merged
merged 1 commit into from
Sep 1, 2019
Merged

Rename FlyCircle to FlyIdle and make it tick TickIdle #16797

merged 1 commit into from
Sep 1, 2019

Conversation

reaperrr
Copy link
Contributor

@reaperrr reaperrr commented Jul 18, 2019 •
edited
Loading

Closes #16197.
Depends on #16695.

@reaperrr reaperrr added this to the Next+1 milestone Jul 18, 2019
@reaperrr
Rename FlyCircle to FlyIdle and make it tick TickIdle
41e074f 
It now handles both hovering and circling aircraft, for consistency.
abcdefg30
abcdefg30 approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@teinarss teinarss merged commit 801f5ba into OpenRA:bleed Sep 1, 2019
@teinarss
Copy link
Contributor

teinarss commented Sep 1, 2019

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/408214481a51f760a813e750467a4e01e1adaf99...b7e62c0e71c3e77a5c96c98a67da61ec4f5ad6ba

@reaperrr reaperrr deleted the air-FlyIdle branch November 23, 2019 20:01
@pchote pchote mentioned this pull request Mar 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcdefg30 abcdefg30 abcdefg30 approved these changes

@teinarss teinarss teinarss approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
Release 20200503
Development

Successfully merging this pull request may close these issues.

Planes don't trigger idle notifications
3 participants
@reaperrr @teinarss @abcdefg30