Add Automatic/Manual/Disabled setting for target line display #16893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
previously approved these changes
Aug 7, 2019
pchote
force-pushed
the
target-line-options
branch
from
576731c
to
d088841
Compare
|
Rebased. |
pchote
force-pushed
the
target-line-options
branch
from
16151ca
to
0853f77
Compare
|
Added a new commit to readd the time-limited automatic target lines on selection for spectators. |
teinarss
reviewed
Aug 8, 2019
| @@ -716,6 +720,29 @@ static bool ShowStatusBarsDropdown(DropDownButtonWidget dropdown, GameSettings s | |||
| return true; | |||
| } | |||
|
|
|||
| static bool ShowTargetLinesDropdown(DropDownButtonWidget dropdown, GameSettings s) | |||
There was a problem hiding this comment.
Probably outside this scope but the return values for this method is never used, this is also true for all *Dropdown methods.
There was a problem hiding this comment.
Outside scope indeed, but added a commit to fix this.
teinarss
previously approved these changes
Aug 10, 2019
pchote
force-pushed
the
target-line-options
branch
from
0853f77
to
b56d2c6
Compare
|
Rebased and updated. |
teinarss
approved these changes
Aug 10, 2019
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16616 and followup discussion in the last couple of days in IRC and discord have raised the point that the current target line behaviour is really not ideal. It would be a shame and wasted opportunity if we don't at least try to improve this as part of our queued-order overhaul in the upcoming release.
This PR replaces the "Display Target Lines" checkbox in the settings menu with a dropdown that has three options:
The final commit switches the default behaviour from the TS/RA2 style to the C&C3 style, which dramatically cleans up the UI when commanding unit blobs. The order flash remains to provide visual confirmation of orders, and players who prefer the feedback of the lines are still able to switch back to Automatic in the settings. The so-far limited feedback from IRC and Discord has been inconclusive, so I would like to get this in to the first playtest to trigger wider discussion.
Closes #16892
Closes #5245 (the target lines provide the visual indication)