Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automatic/Manual/Disabled setting for target line display #16893

Merged
merged 5 commits into from Aug 10, 2019

Conversation

@pchote
Copy link
Member

commented Aug 7, 2019

#16616 and followup discussion in the last couple of days in IRC and discord have raised the point that the current target line behaviour is really not ideal. It would be a shame and wasted opportunity if we don't at least try to improve this as part of our queued-order overhaul in the upcoming release.

This PR replaces the "Display Target Lines" checkbox in the settings menu with a dropdown that has three options:

  • Automatic: Lines are automatically displayed for 2.4 seconds on selection / order, and are always visible while the waypoint mode (shift) is active (TS/RA2/previous-OpenRA style)
  • Manual: Lines are only displayed while the waypoint mode is active (C&C3 style)
  • Disabled: Lines are never displayed (TD/RA1 style)

The final commit switches the default behaviour from the TS/RA2 style to the C&C3 style, which dramatically cleans up the UI when commanding unit blobs. The order flash remains to provide visual confirmation of orders, and players who prefer the feedback of the lines are still able to switch back to Automatic in the settings. The so-far limited feedback from IRC and Discord has been inconclusive, so I would like to get this in to the first playtest to trigger wider discussion.

Closes #16892
Closes #5245 (the target lines provide the visual indication)

@pchote pchote added this to the Next Release milestone Aug 7, 2019

@matjaeck
Copy link
Contributor

left a comment

Manual target lines work really well for me, it's much cleaner! I could imagine that players find the order flash in RA and TS on snow maps too hard to see, so this might be a topic for the future.

@pchote pchote force-pushed the pchote:target-line-options branch from 576731c to d088841 Aug 7, 2019

@pchote

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

Rebased.

@pchote pchote force-pushed the pchote:target-line-options branch from 16151ca to 0853f77 Aug 8, 2019

@pchote

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

Added a new commit to readd the time-limited automatic target lines on selection for spectators.
This partly supersedes the changes from #16876.

@@ -716,6 +720,29 @@ static bool ShowStatusBarsDropdown(DropDownButtonWidget dropdown, GameSettings s
return true;
}

static bool ShowTargetLinesDropdown(DropDownButtonWidget dropdown, GameSettings s)

This comment has been minimized.

Copy link
@teinarss

teinarss Aug 8, 2019

Contributor

Probably outside this scope but the return values for this method is never used, this is also true for all *Dropdown methods.

This comment has been minimized.

Copy link
@pchote

pchote Aug 10, 2019

Author Member

Outside scope indeed, but added a commit to fix this.

@teinarss
Copy link
Contributor

left a comment

Otherwise it looks good

@pchote pchote force-pushed the pchote:target-line-options branch from 0853f77 to b56d2c6 Aug 10, 2019

@pchote

This comment has been minimized.

Copy link
Member Author

commented Aug 10, 2019

Rebased and updated.

@teinarss teinarss merged commit 702f4d1 into OpenRA:bleed Aug 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:target-line-options branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.