Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease SearchFromProcRadius and SearchFromOrderRadius #16920

Merged
merged 5 commits into from Aug 11, 2019

Conversation

@abcdefg30
Copy link
Member

commented Aug 10, 2019

As discussed on IRC and Discord. Values suggested and approved by @netnazgul.
Only thing I changed was the radii for the weed harvester, it needs to cover longer distances (so it is double the new value now).

@abcdefg30 abcdefg30 added this to the Next Release milestone Aug 10, 2019

@pchote

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

We need to be careful here - as I noted in IRC and Discord it turns out that SearchFromProcRadius is, most of the time, not being used to search from the refinery. It is instead being used from the harvesters location in the field, which means that any values derived from testing will be mostly sampling the wrong thing.

Can we instead introduce a new SearchFromHarvesterRadius (maybe combining/renaming with SearchFromOrderRadius?) and set that to 15?

@tovl

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

ScanFromProcRadius should only be used to scan from the refinery. If it is not, then that is a bug.

ScanFromOrderRadius is indeed a misnomer now, because it scans from the last harvested position most of the time, unless explicitly ordered (and then only the first time).

@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented Aug 10, 2019

Updated with the suggested changes and renamed SearchFromOrderRadius to SearchFromHarvesterRadius.

@abcdefg30 abcdefg30 force-pushed the abcdefg30:harvVal branch from 42f3f66 to d376635 Aug 10, 2019

@@ -0,0 +1,30 @@
using System.Collections.Generic;

This comment has been minimized.

Copy link
@pchote

pchote Aug 10, 2019

Member

File is missing the standard license header

@abcdefg30 abcdefg30 force-pushed the abcdefg30:harvVal branch from d376635 to 06b6df7 Aug 10, 2019

@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented Aug 10, 2019

Updated.

@pchote
pchote approved these changes Aug 10, 2019

@pchote pchote added the PR: Needs +2 label Aug 10, 2019

@teinarss teinarss merged commit ea80a13 into OpenRA:bleed Aug 11, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:harvVal branch Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.