Remove BuildingInfluence #18689
Merged
Remove BuildingInfluence #18689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchote
force-pushed
the
remove-buildinginfluence
branch
from
3a5ecaa
to
1f8bfbb
Compare
phrohdoh
reviewed
Oct 22, 2020
OpenRA.Mods.Common/UpdateRules/Rules/20200503/RemoveBuildingInfluence.cs
Show resolved
Hide resolved
pchote
force-pushed
the
remove-buildinginfluence
branch
from
1f8bfbb
to
ff21fb2
Compare
|
Rebased. |
abcdefg30
reviewed
Oct 24, 2020
teinarss
reviewed
Oct 24, 2020
Buildings are already excluded by the ActorMap checks.
pchote
force-pushed
the
remove-buildinginfluence
branch
from
ff21fb2
to
4d5a393
Compare
pchote
force-pushed
the
remove-buildinginfluence
branch
from
4d5a393
to
34bf143
Compare
|
Fixed. |
abcdefg30
approved these changes
Oct 26, 2020
This was referenced Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements my version of #15744, which this supersedes.
The remaining uses of
BuildingInfluenceappear to be completely redundant (e.g. crate spawning, adjacency checks), needlessly limiting (e.g. plug placement, which in theory should now work for upgrading mobile unit), or at worst (hopefully) not significantly faster than querying theActorMapwhich also contains the buildings.Depends on #18688.
According to previous discussions, this may in theory allow us to revert #13796 for simpler code, and may also solve #14676, but I have forgotten the context surrounding those so don't want to claim too much.