Remove highlight, disabled, and iron curtain palettes #18550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchote
force-pushed
the
renderable-modifiers
branch
2 times, most recently
from
b005262
to
44d55c1
Compare
pchote
force-pushed
the
renderable-modifiers
branch
from
44d55c1
to
772c94d
Compare
pchote
force-pushed
the
renderable-modifiers
branch
from
772c94d
to
b120492
Compare
pchote
force-pushed
the
renderable-modifiers
branch
from
b120492
to
046d356
Compare
pchote
force-pushed
the
renderable-modifiers
branch
2 times, most recently
from
e9ac865
to
9cdb298
Compare
|
Rebased and adjusted update rule to account for the prep branch. |
pchote
force-pushed
the
renderable-modifiers
branch
2 times, most recently
from
10ed0b1
to
996ed49
Compare
teinarss
reviewed
Dec 28, 2020
pchote
force-pushed
the
renderable-modifiers
branch
2 times, most recently
from
8cf3cdb
to
639195d
Compare
|
Updated. |
phrohdoh
reviewed
Dec 28, 2020
|
needs a rebase. |
pchote
force-pushed
the
renderable-modifiers
branch
from
639195d
to
11a5780
Compare
pchote
force-pushed
the
renderable-modifiers
branch
from
11a5780
to
acbc5cf
Compare
|
Is there anything more I can do to help get this (and #18728) merged? They have been ready for months, and are major blockers for pretty much everything that I want to work on, which includes several long-wanted modding features. |
teinarss
approved these changes
Jan 5, 2021
abcdefg30
approved these changes
Jan 5, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the first step towards replacing palette-based effects with RGBA-compatible techniques.
The first three commits do some basic reorganization and expands the core rendering plumbing to support per-sprite alpha and a new tint replacement mode. The last two commits (exactly) recreate the current target flash and WithColoredOverlay effects using tint/alpha and removes the now unnecessary palette definitions.