New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port macOS and Linux release packages to .NET 5 #18955
Conversation
Added a commit to enable trimming, which saves a further 10MB on both macOS and Windows, and another commit to switch the non-compat builds to the ULFO format for faster decompression. Updated test builds: https://github.com/pchote/OpenRA/releases/tag/devtest-20201223-8 Windows should now be tested too since it is affected by trimming. |
N/A confirmed on Discord that the -8 test build works on macOS 10.13. |
Rebased on latest version of #17989 and added some more commits to switch the Linux AppImages to NET 5 and remove the now-obsolete runtime assemblies check. This now just leaves the makefile and related bits that were dropped out of the first PR to complete the full migration. Updated test builds: https://github.com/pchote/OpenRA/releases/tag/devtest-20201228 I have tested that the AppImages run fine on Ubuntu 14.04 and CentOS 7, so we should not be dropping any distros with this switch. |
|
Updated. I'll wait for #17989 to be merged before tagging another test build. |
Rebased. Updated (and hopefully final) test builds: https://github.com/pchote/OpenRA/releases/tag/devtest-20210101 |
The
|
Fixed. New test build: https://github.com/pchote/OpenRA/releases/tag/devtest-20210102 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Linux.
Is there anything else I can do here to help get this PR merged? I wanted to delay the .NET 5 migration into Next + 1 so we could maximize the amount of testing and time to work around any issues on the new toolchain. This time is currently going wasted, until the next PR (which depends on this one) is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Portable build worked fine on Windows 10.
This follows #17989 by switching over the macOS packages, which requires two additional changes to work well:
mod.app/Contents/MacOS
subdir, usingEngine.EngineDir
to point to the data inmod.app/Contents/Resources
. This brings us in line with the app bundling convention for putting all executable code inMacOS
, and more importantly fixes the app icon otherwise being missing.I could only find one reference online to anybody using this hard link trick before, so i'm not 100% sure this will be compatible on all systems. It works for me on macOS 11.0.1, but we should get some additional testing on at least macOS 10.13 before we merge this.
Test builds: https://github.com/pchote/OpenRA/releases/tag/devtest-20201223-4