Merged
Conversation
Member
|
Will this conflict with #21175? |
Member
Author
Yes. |
PunkPun
reviewed
Oct 30, 2023
Member
PunkPun
left a comment
PunkPun
left a comment
There was a problem hiding this comment.
These rules seem fairly smart, overall LGTM. Left a few comments
OpenRA.Mods.Cnc/UtilityCommands/ImportTiberianDawnMapCommand.cs
Outdated
Show resolved
Hide resolved
Member
It doesn't look lie it conflicts, the changes that overlap are identical |
RoosterDragon
force-pushed
the
style-ros-small
branch
from
aeaf6d7 to
75a4ab2
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #21013.
Enforces 23 Roslynator rules across the project.
I have batched together a PR for these rules as they each had limited existing violations and are hopefully uncontroversial. However fixes are arranged per commit so we can easily bikeshed over rules as desired.
Reviewing with Ignore Whitespace will make the diff in a couple of files less cumbersome.
See https://josefpihrt.github.io/docs/roslynator/analyzers for explanation of each rule.