Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more Roslynator rules #21176

Merged
merged 23 commits into from Oct 30, 2023
Merged

Conversation

RoosterDragon
Copy link
Member

@RoosterDragon RoosterDragon commented Oct 30, 2023

Following on from #21013.

Enforces 23 Roslynator rules across the project.

I have batched together a PR for these rules as they each had limited existing violations and are hopefully uncontroversial. However fixes are arranged per commit so we can easily bikeshed over rules as desired.

Reviewing with Ignore Whitespace will make the diff in a couple of files less cumbersome.

See https://josefpihrt.github.io/docs/roslynator/analyzers for explanation of each rule.

@pchote
Copy link
Member

pchote commented Oct 30, 2023

Will this conflict with #21175?

@RoosterDragon
Copy link
Member Author

Will this conflict with #21175?

Yes.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These rules seem fairly smart, overall LGTM. Left a few comments

OpenRA.Mods.Common/Traits/AcceptsDeliveredExperience.cs Outdated Show resolved Hide resolved
OpenRA.Game/Map/Map.cs Show resolved Hide resolved
@PunkPun
Copy link
Member

PunkPun commented Oct 30, 2023

Will this conflict with #21175?

It doesn't look lie it conflicts, the changes that overlap are identical

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun PunkPun merged commit fc0bdce into OpenRA:bleed Oct 30, 2023
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Oct 30, 2023

Changelog

@RoosterDragon RoosterDragon deleted the style-ros-small branch November 3, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants