New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable more Roslynator rules #21176
Enable more Roslynator rules #21176
Conversation
Will this conflict with #21175? |
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These rules seem fairly smart, overall LGTM. Left a few comments
OpenRA.Mods.Cnc/UtilityCommands/ImportTiberianDawnMapCommand.cs
Outdated
Show resolved
Hide resolved
It doesn't look lie it conflicts, the changes that overlap are identical |
aeaf6d7
to
75a4ab2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Following on from #21013.
Enforces 23 Roslynator rules across the project.
I have batched together a PR for these rules as they each had limited existing violations and are hopefully uncontroversial. However fixes are arranged per commit so we can easily bikeshed over rules as desired.
Reviewing with Ignore Whitespace will make the diff in a couple of files less cumbersome.
See https://josefpihrt.github.io/docs/roslynator/analyzers for explanation of each rule.