Fix pillbox not uncloaking upon firing

[PunkPun]

Regression from #20675
Fixes #21093

[JovialFeline]

Fixes the tests I had, including the odd multi-passenger pillbox on wheels. 👌

[dnqbob]

Call other actor's INotifyAttack will result in messing up traits like GrantConditionOnAttack and crashing.

Exception of type `System.InvalidOperationException`: Attempting to revoke condition with invalid token 2 for hbox 292.
   at OpenRA.Actor.RevokeCondition(Int32 token) in D:\work\Projects\Github\OpenRA\OpenRA.Game\Actor.cs:line 583
   at OpenRA.Mods.Common.Traits.GrantConditionOnAttack.RevokeInstance(Actor self, Boolean revokeAll) in D:\work\Projects\Github\OpenRA\OpenRA.Mods.Common\Traits\Conditions\GrantConditionOnAttack.cs:line 77
   at OpenRA.TraitDictionary.TraitContainer`1.ApplyToAllTimed(Action`2 action, String text) in D:\work\Projects\Github\OpenRA\OpenRA.Game\TraitDictionary.cs:line 312
   at OpenRA.World.Tick() in D:\work\Projects\Github\OpenRA\OpenRA.Game\World.cs:line 458
   at OpenRA.Game.InnerLogicTick(OrderManager orderManager) in D:\work\Projects\Github\OpenRA\OpenRA.Game\Game.cs:line 646
   at OpenRA.Game.LogicTick() in D:\work\Projects\Github\OpenRA\OpenRA.Game\Game.cs:line 661
   at OpenRA.Game.Loop() in D:\work\Projects\Github\OpenRA\OpenRA.Game\Game.cs:line 830
   at OpenRA.Game.Run() in D:\work\Projects\Github\OpenRA\OpenRA.Game\Game.cs:line 883
   at OpenRA.Game.InitializeAndRun(String[] args) in D:\work\Projects\Github\OpenRA\OpenRA.Game\Game.cs:line 313
   at OpenRA.Launcher.Program.Main(String[] args) in D:\work\Projects\Github\OpenRA\OpenRA.Launcher\Program.cs:line 32

Testcase: replace the same file(yaml) in OpenRA-RA
structures.zip

[dnqbob]

I really don't recommend use this way to fix the uncloak issue because there can be countless dangerous edge cases on traits like GrantConditionOnAttack (for example you also need to test cases when IsCyclic is enabled and applying proper and hacky fix after that).

[PunkPun]

Fixed the crash

[PunkPun]

I think it makes perfect sense for infantry to call the pillbox's NotifyAttack. Not having that created weird exceptions and limitations to the AttackGarrison trait.

[dnqbob]

Then I recommend a detailed test on all INotifiedAttack related traits. They can have flaws on function but should never crash.

[PunkPun]

This fixes traits like ammo and reveal on fire not working in pillboxes

[abcdefg30]

Code changes lgtm, but untested.

P.S. It feels like AttackGarrisoned shouldn't (re-)use Armaments from the passengers, but that is not for this PR.

[abcdefg30]

Changelog