Fix Armament not working properly with value 0 in BurstDelays#20675
Merged
Mailaender merged 2 commits intoOpenRA:bleedfrom Sep 23, 2023
Merged
Fix Armament not working properly with value 0 in BurstDelays#20675Mailaender merged 2 commits intoOpenRA:bleedfrom
Mailaender merged 2 commits intoOpenRA:bleedfrom
Conversation
Contributor
Add: by using this properly instead of massing armaments we can also get performance improve, since the armaments are traversed every time when AutoTarget check target and Attackbase fire at target. |
anvilvapre
reviewed
Feb 19, 2023
Contributor
|
I tested this change on OpenE2140 and it works fine. Here are the weapon and armament definition: ucs_vehicles_tiger_assault:
ReloadDelay: 40
Report: 5.smp
ValidTargets: Ground
Burst: 8
BurstDelays: 0, 10, 0, 10, 0, 10, 0Armament@PRIMARY:
Weapon: ucs_vehicles_tiger_assault
Recoil: 64
RecoilRecovery: 38
LocalOffset: 100,-410,0, 100,410,0
LocalYaw: 0, 0It does not look as concise as the |
abcdefg30
reviewed
Jun 24, 2023
RoosterDragon
approved these changes
Aug 22, 2023
Mailaender
reviewed
Sep 23, 2023
48bb6c1 to
240f5b1
Compare
Mailaender
approved these changes
Sep 23, 2023
Member
This was referenced Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes: #20601
This allows us to simplify yaml definitions, as I've done in all non-d2k mods.
It will also make it easier for the encyclopedia to read armament definitions when we get to it.