AutoTarget unarmed buildings again to help AI crush it's enemy

[Mailaender]

This reverts #3337 for ra and the changes introduced by @psydev for d2k/cnc in that regard. The AI needs AutoTarget because it solely uses AttackMove to fight it's enemies.

[chrisforbes]

I think it would be better to fix the AI.

[ScottNZ]

Me too

[pchote]

We're going to need some fix to this issue before the playtest - shipping a broken AI isn't really an option.

[Mailaender]

See, this playtest will never be released on June :P

[pchote]

A release on Sunday is still entirely plausible.

A simple fix for the AI would be to extend AutoTargetIgnore with flags for IgnoredByHumans / IgnoredByBots.

On 28/06/2013, at 4:37 AM, Matthias Mailänder notifications@github.com wrote:

See, this playtest will never be released on June :P

—
Reply to this email directly or view it on GitHub.

[pchote]

I would like to take this as-is for the next playtest unless @chrisforbes or @ScottNZ really object.
This pr gets us back to the working state of release-20130514. We can redo the enhancements that broke this for a later release.

[pchote]

A simple fix for the AI would be to extend AutoTargetIgnore with flags for IgnoredByHumans / IgnoredByBots.

The engine has advanced, and we can now fix this even more generally. Elaborating as requested by @rob-v.

• Replace AutoTargetIgnore with an AutoTargetable trait that has exposes a string[] Types field.
• Add a matching string[] Types to AutoTarget and only target actors that have an intersecting types list
• Introduce a GrantConditionOnBotOwner trait that grants a condition when an actor is owned by a bot.
• Add HoldFireCondition, ReturnFireCondition, DefendCondition and AttackAnythingCondition fields to AutoTarget to grant conditions based on the actor's current stance.
• Tag each actor type (infantry, vehicles, buildings, etc) with their respective type, and set up two instances of AutoTarget:
  • Actors owned by a bot or in the AttackAnything stance should autotarget everything
  • Actors owned by a human and not in the AttackAnything stance should autotarget everything except buildings.

This could extend even further in the future by adding relative priorities for each autotarget type for things like the threat rating node in TS and ai difficulties in all mods.