Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guest list #8588

Closed
2 tasks
acrossthestars07 opened this issue Jan 14, 2019 · 16 comments
Closed
2 tasks

guest list #8588

acrossthestars07 opened this issue Jan 14, 2019 · 16 comments
Assignees
Labels
investigate Not sure what the problem is yet.

Comments

@acrossthestars07
Copy link

acrossthestars07 commented Jan 14, 2019

-->
OS: Windows 10
Version: 0.2.1
Commit/Build: 8ac731e

Hello!
I seem to be encountering a problem when viewing the guests in the Guest Window. When I scroll down the lowest I can go, I cannot see all of my guests. Even when I expand the window, the lowest it will go is to the "R" names. I took a screenshot to show you. I get the same problem when I select individual guest's thoughts as well.
Any thoughts on what I can do to fix this?

Thanks so much!
Fill in the placeholders below. Delete any headings and placeholders that you do not fill in.
volcania 2019-01-14 04-36-04

  • Reproducible in RCT2 (vanilla)?
  • Specific to multiplayer?

Steps to reproduce:
1.
2.

Dump file

Screenshots / Video:

Save game:

@Gymnasiast
Copy link
Member

You didn't fill in the form correctly. The version and build hash are especially important.

@Gymnasiast Gymnasiast added the invalid/incomplete Not applicable or missing information. label Jan 14, 2019
@acrossthestars07
Copy link
Author

Sorry about that!
I have the latest version available: 0.2.1 build 8ac731e
Is that all you needed? Not sure what the build hash is unless I entered it just now with the version. Let me know. Thanks!

@Gymnasiast
Copy link
Member

8ac731e is indeed a build hash.

0.2.1, build 8ac731e is indeed the latest release version. However, we also have "develop" builds. Could you try switching to it to see if it solves the problem? If you use the OpenRCT2 Launcher, look in the options. If you're using regular, downloaded builds, download the latest build off openrct2.org .

@Gymnasiast Gymnasiast added investigate Not sure what the problem is yet. and removed invalid/incomplete Not applicable or missing information. labels Jan 17, 2019
@jensj12
Copy link
Contributor

jensj12 commented Jan 17, 2019

Can confirm on 51fc2fe. The cutoff point seems to be around 2650 guests on the tested park. Open any park and send a few large trams.

@Gymnasiast
Copy link
Member

Odd. We have had this problem before, not sure why pagination would be broken again.

@Gymnasiast Gymnasiast self-assigned this Jan 17, 2019
@tomlankhorst
Copy link
Contributor

At devel, there's the scrolling list and a page dropdown... together they show all names.

image

@Gymnasiast
Copy link
Member

Gymnasiast commented Jan 18, 2019

I have been able to reproduce. If you have 3100-3200 guests in your park, you will indeed not be able to scroll down all the way, but there won't be a page dropdown yet - that page dropdown only appears when crossing the 3500 guest mark, it appears. Perhaps we should just paginate per 2000 guests, seems more than enough to me.

Edit: no, it does the same when changing it to 2000... how odd...

@ocalhoun6
Copy link
Contributor

While we're at it, wouldn't it be more intuitive if it automatically skipped to page 2 (and so on) whenever you scrolled down to the very bottom of the page and attempted to scroll further?

@tomlankhorst
Copy link
Contributor

@Gymnasiast There's the scroll widget limit and the pagination limit. These currently do not match.

_window_guest_list_num_pages = (int32_t)std::ceil((float)numGuests / 3173);

How to track down the maximum number of items in the scroll widget?

@AaronVanGeffen
Copy link
Member

How to track down the maximum number of items in the scroll widget?

I believe it was split in order to not make the scrollbar thumb too small. There is no set limitation to how big a scrollable area can be.

@tomlankhorst
Copy link
Contributor

tomlankhorst commented Jan 18, 2019

Seems that the height cutoff 0x7BF2 (=31730) and the per-page number (3173) were not consistent with SCROLLABLE_ROW_HEIGHT (12)

@AaronVanGeffen
Copy link
Member

Sounds like an unfortunate side-effect of #6522. This has been in for a while!

@acrossthestars07
Copy link
Author

Sorry, is this problem resolved? i see the thread is marked as closed.
So I tried to download the developer version of the game, but I had a ton of issues. I have a Windows laptop, so I tried to download both the 64 and the 86 version. Every time I tried to open the download, a window popped up saying that I did not have administrative permission, then it aborted. My antivirus went crazy too. Do I need to download the developer version in order for this problem to be resolved? If so, I might need some help.
Thanks so much!

@Gymnasiast
Copy link
Member

Yes, this bug is solved.

Some antivirus programs don't trust OpenRCT2 for some reason. You need to whitelist OpenRCT2 for it to work, or switch to another AV program.

The newest develop version (which is indeed what you need) can be download here: http://cdn.limetric.com/games/openrct2/0.2.1/develop/57193aa/7/OpenRCT2-0.2.1-develop-57193aa-windows-x64.exe
You can also use the launcher, which auto-updates the game for you. It can be downloaded here: https://github.com/LRFLEW/OpenRCT2Launcher/releases/download/v0.0.7/OpenRCT2Launcher-win.exe

@janisozaur
Copy link
Member

Keep in mind there's no launcher for the launcher so you need to update it manually whenever it's required.

@IntelOrca
Copy link
Contributor

Keep in mind there's no launcher for the launcher so you need to update it manually whenever it's required.

It does however notify you when there is an update for the launcher available:
https://github.com/LRFLEW/OpenRCT2Launcher/blob/develop/updater.cpp#L85

ZehMatt pushed a commit to ZehMatt/OpenRCT2 that referenced this issue Jan 24, 2019
ZehMatt pushed a commit to ZehMatt/OpenRCT2 that referenced this issue Jan 24, 2019
janisozaur added a commit that referenced this issue Mar 13, 2019
- Feature: [#4418] Allow steep slopes on the side-friction roller coaster.
- Feature: [#7726] Add shortcut to advance one tick.
- Feature: [#7956, #7964] Add sprite font glyphs for Hungarian and some Czech letters.
- Feature: [#7971] Toolbox option to open custom content folder.
- Feature: [#7980] Allow data path for RCT1 to be specified by a command line argument.
- Feature: [#8073] Auto-upload minidumps to backtrace.io (optional, MSVC/Windows only)
- Feature: [#8078] Add save_park command to in-game console.
- Feature: [#8080] New console variable "current_rotation" to get or set view rotation.
- Feature: [#8098] Glyph for Russian rouble sign.
- Feature: [#8099] Add Powered Launch mode to Inverted RC (for RCT1 parity).
- Feature: [#8190] Allow building footpaths on 'corner down' terrain.
- Feature: [#8191] Allow building on-ride photos and water S-bends on the Water Coaster.
- Feature: [#8259] Add say command to in-game console.
- Feature: [#8374] Add replay system.
- Feature: [#8377] Add option to adjust amount of autosaves to keep.
- Feature: [#8458] Add sprite sorting benchmark.
- Feature: [#8583] Add boosters to water coaster.
- Feature: [#8648] Add optional chat button to top toolbar in multiplayer games.
- Feature: [#8652] Add network window including a graph for data usage visualisation.
- Feature: [#8670] Add ability to download missing objects when loading a park.
- Change: [#7961] Add new object types: station, terrain surface, and terrain edge.
- Change: [#8222] The climate setting has been moved from objective options to scenario options.
- Change: [#8718] Allow TARMAC object to be removed when running the `remove_unused_objects` command.
- Change: [#8718] No longer require the generic scenery groups and tarmac footpath to be checked when creating a scenario.
- Change: [#8734] Disable kick button in multiplayer window when unable to use it.
- Fix: [#3832] Changing the colour scheme of track pieces does not work in multiplayer.
- Fix: [#4094] Coasters with long flat-to-steep pieces offer them in diagonal mode (original bug).
- Fix: [#5684] Player list can desync between clients and server and can crash.
- Fix: [#6191] OpenRCT2 fails to run when the path has an emoji in it.
- Fix: [#7439] Placement messages have mixed strings
- Fix: [#7473] Disabling sound effects also disables "Disable audio on focus loss".
- Fix: [#7536] Android builds fail to start.
- Fix: [#7689] Deleting 0-tile maze gives a MONEY32_UNDEFINED (negative) refund.
- Fix: [#7828] Copied entrances and exits stay when demolishing ride.
- Fix: [#7945] Client IP address is logged as `(null)` in server logs.
- Fix: [#7952] Performance drop caused by code refactor.
- Fix: [#7954] Key validation fails on Windows due to non-ASCII user / player name.
- Fix: [#7975] Inspection flag not cleared for rides which are set to never be inspected (original bug).
- Fix: [#7985] Giant Screenshot ignores 'Map rendering' settings.
- Fix: [#7987] Broken track designs increase money by MONEY32_UNDEFINED.
- Fix: [#7991] Scenery and footpaths on Construction Rights tiles can be deleted using Clear Scenery.
- Fix: [#8034] Vanilla sprites are broken when making screenshots from command line.
- Fix: [#8045] Crash when switching between languages.
- Fix: [#8062] In multiplayer warnings for unstable cheats are shown when disabling them.
- Fix: [#8090] Maze designs saved incorrectly.
- Fix: [#8101] Title sequences window flashes after opening.
- Fix: [#8120] Crash trying to place peep spawn outside of map.
- Fix: [#8121] Crash Renaming park with server logging enabled.
- Fix: [#8139] Buying land costs money when the game is in "no money" mode.
- Fix: [#8141] Attempting to build entrance/exit on station 2 does not work.
- Fix: [#8142] Reliability of mazes and crooked houses can go below 100%.
- Fix: [#8187] Cannot set land ownership over ride entrances or exits in sandbox mode.
- Fix: [#8200] Incorrect behaviour when removing entrances and exits that are on the same tile.
- Fix: [#8204] Crash when tile element has no surface elements.
- Fix: [#8264] Rides and scenery placeable outside of map with ZC and Sandbox mode enabled.
- Fix: [#8335] Rides with arbitrary ride types can crash the game when they break down.
- Fix: [#8358] Infinite loop when changing vehicle count on stopped ride.
- Fix: [#8402] Crash closing a window in some cases.
- Fix: [#8431] Crash when game action logging is enabled.
- Fix: [#8433] Crash if master server response is not valid JSON.
- Fix: [#8434] Crash if curl_easy_init fails.
- Fix: [#8443] Crash when selecting the current vehicle for ride that has none available.
- Fix: [#8456] Junior booster track piece doesn't connect properly.
- Fix: [#8464] Crash on game shutdown.
- Fix: [#8469] Crash modifying colour on hacked rides.
- Fix: [#8508] Underground roto-drop is not going up.
- Fix: [#8555] Multiplayer window text limits are not computed properly.
- Fix: [#8572] Steel Twister track pieces ID 64 and 65 drawn incorrectly.
- Fix: [#8585] Part of track missing on air powered vertical coaster.
- Fix: [#8588] Guest list scrolling breaks above ~2000 guests.
- Fix: [#8591] Game loop does not run at a consistent tick rate of 40 Hz.
- Fix: [#8647] Marketing campaigns check for entry fees below £1 (original bug).
- Fix: [#8653] Crash when peeps attempt to enter a ride with no vehicles.
- Fix: [#8720] Desync due to boats colliding with ghost pieces.
- Fix: [#8739] Savegame from original game crashes when cruising through map.
- Fix: [#8742] Access violation in vehicle_update_sound_params.
- Fix: [#8804] Raising water shows money effect at the bottom rather than new height.
- Fix: [#8811] Some fields in the sv6 save file not being copied correctly.
- Fix: [#8824] Invalid read in footpath_chain_ride_queue.
- Improved: [#2940] Allow mouse-dragging to set patrol area (Singleplayer only).
- Improved: [#7730] Draw extreme vertical and lateral Gs red in the ride window's graph tab.
- Improved: [#7930] Automatically create folders for custom content.
- Improved: [#7980] Show the full path of the scenario in the scenario select window.
- Improved: [#7993] Allow assigning a keyboard shortcut for opening the tile inspector.
- Improved: [#8107] Support Discord release of RCT2.
- Improved: [#8491] Highlight entrance and exit with different colours in track design previews.
- Improved: Almost completely new Hungarian translation.
- Removed: [#7929] Support for scenario text objects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigate Not sure what the problem is yet.
Projects
None yet
Development

No branches or pull requests

8 participants