Use std::unique_ptr in context

[ZehMatt]

I refactored some shared_ptrs to unique_ptrs and return the reference instead of shared_ptr, this should clarify the lifetime of the object and slightly improves the performance.

Issue: #7949

[janisozaur]

unused

[janisozaur]

extra whitespace

[janisozaur]

Needs some formatting:

--- src/openrct2/ParkImporter.h	(original)
+++ src/openrct2/ParkImporter.h	(reformatted)
@@ -65,8 +65,7 @@
 {
     std::unique_ptr<IParkImporter> Create(const std::string& hintPath);
     std::unique_ptr<IParkImporter> CreateS4();
-    std::unique_ptr<IParkImporter> CreateS6(
-        IObjectRepository& objectRepository, IObjectManager& objectManager);
+    std::unique_ptr<IParkImporter> CreateS6(IObjectRepository& objectRepository, IObjectManager& objectManager);
 
     bool ExtensionIsRCT1(const std::string& extension);
     bool ExtensionIsScenario(const std::string& extension);
--- src/openrct2/rct2/S6Importer.cpp	(original)
+++ src/openrct2/rct2/S6Importer.cpp	(reformatted)
@@ -845,8 +845,7 @@
     }
 };
 
-std::unique_ptr<IParkImporter> ParkImporter::CreateS6(
-    IObjectRepository& objectRepository, IObjectManager& objectManager)
+std::unique_ptr<IParkImporter> ParkImporter::CreateS6(IObjectRepository& objectRepository, IObjectManager& objectManager)
 {
     return std::make_unique<S6Importer>(objectRepository, objectManager);
 }
--- src/openrct2/ride/Ride.cpp	(original)
+++ src/openrct2/ride/Ride.cpp	(reformatted)
@@ -234,7 +234,7 @@
 {
     rct_ride_entry* result = nullptr;
     auto& objMgr = OpenRCT2::GetContext()->GetObjectManager();
-    
+
     auto obj = objMgr.GetLoadedObject(OBJECT_TYPE_RIDE, index);
     if (obj != nullptr)
     {

[janisozaur]

@ZehMatt in #7949 you mentioned you noticed some performance issues with the way it was done before, is there any impact on performance with those changes?

[ZehMatt]

Yea slightly not that major, however in combination with my other PR its no longer on the hot path list.

[janisozaur]

@ZehMatt looks like it needs a rebase

[ZehMatt]

I rebased and tested it once more, should be good from my end.