Auto-upload crashes to backtrace.io #8073

janisozaur · 2018-10-09T21:32:53Z

This is a proof-of-concept of https://backtrace.io integration.

It works using breakpad's native uploader and is capable of automatically creating issues such as #8072 (using the crash reported in #8047).

I have manually uploaded the symbols from a build, it would require some automation, a case of uploading .pdb to one more place.

As of now this is done using 30-day trial on backtrace, things to do to make this all work:

apply for open-source exemption (1000crashes/month, 90 days of retention) see https://documentation.backtrace.io/open_source/
provide accounts for other team members
upload the symbols to backtrace as part of build

I expect some discussion to follow…

janisozaur · 2018-10-18T20:54:11Z

Our account got upgraded to the open source offering.

IntelOrca · 2018-10-18T22:57:17Z

scripts/ps/appveyor_deploy.ps1

@@ -14,6 +14,11 @@ if ($nottesting -and $notvs2015)
        if (${env:APPVEYOR_REPO_TAG} -eq "true" -or ${env:APPVEYOR_REPO_BRANCH} -match "^develop$|^push/")
        {
            msbuild openrct2.proj /t:UploadArtifacts /logger:"C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll"
+            # PowerShell is being stupid here and hijacks calls to curl, need to call it via curl.exe explicitly


Please change the comment. PowerShell is not being stupid. There is by default an alias of curl to Invoke-WebRequest.

Being stupid by design is still stupid. Hijacking calls to a widely available utility that doesn't even try to mimic original's behaviour is stupid.

IntelOrca · 2018-10-18T23:00:33Z

src/openrct2/platform/Crash.cpp

+static bool UploadMinidump(const wchar_t* dumpPath)
+{
+    std::wstring url(
+        L"https://submit.backtrace.io/openrct2/e9e6d681fafdeac9f6131b4b59a155d54bebad567a8c0380d70643f4414819f5/minidump");


This could be extracted to a constant at the top of the file. What does the long hex string represent?

Access token

IntelOrca · 2018-10-18T23:06:40Z

Do the dump files get compressed before being sent to the server? One mini dump I got was ~8 MiB, but compressed it was ~500 KiB. I am just wondering whether we need to show a status box to say it is uploading if it is likely to take awhile.

janisozaur · 2018-10-19T07:50:12Z

It is not compressed. I can look into what we can do with the tools we already have, but I'd like to limit amount of work being done in an already crashed state.

I can add a note stating the upload my take a while and won't show progress, maybe add a message box once it's done.

IntelOrca · 2018-10-19T08:54:40Z

I wonder if it automatically gets compressed using gzip over HTTP, providing the server returns an accept header for gzip.

janisozaur · 2018-10-24T13:09:12Z

I've updated this with ability to gzip minidumps, but would need someone to test it out. The part that needs testing is if the a) dumps get compressed correctly b) they get accepted as gzipped dumps on backtrace.io side

janisozaur · 2018-10-25T20:28:43Z

I've disabled gzip for now, Backtrace's support said it's likely on their roadmap and will come back to me with confirmation/ETA.

janisozaur · 2018-10-25T21:45:02Z

See #8157 for a crash generated using (manually inserted bug) 76b6bd8

- Feature: [#4418] Allow steep slopes on the side-friction roller coaster. - Feature: [#7726] Add shortcut to advance one tick. - Feature: [#7956, #7964] Add sprite font glyphs for Hungarian and some Czech letters. - Feature: [#7971] Toolbox option to open custom content folder. - Feature: [#7980] Allow data path for RCT1 to be specified by a command line argument. - Feature: [#8073] Auto-upload minidumps to backtrace.io (optional, MSVC/Windows only) - Feature: [#8078] Add save_park command to in-game console. - Feature: [#8080] New console variable "current_rotation" to get or set view rotation. - Feature: [#8098] Glyph for Russian rouble sign. - Feature: [#8099] Add Powered Launch mode to Inverted RC (for RCT1 parity). - Feature: [#8190] Allow building footpaths on 'corner down' terrain. - Feature: [#8191] Allow building on-ride photos and water S-bends on the Water Coaster. - Feature: [#8259] Add say command to in-game console. - Feature: [#8374] Add replay system. - Feature: [#8377] Add option to adjust amount of autosaves to keep. - Feature: [#8458] Add sprite sorting benchmark. - Feature: [#8583] Add boosters to water coaster. - Feature: [#8648] Add optional chat button to top toolbar in multiplayer games. - Feature: [#8652] Add network window including a graph for data usage visualisation. - Feature: [#8670] Add ability to download missing objects when loading a park. - Change: [#7961] Add new object types: station, terrain surface, and terrain edge. - Change: [#8222] The climate setting has been moved from objective options to scenario options. - Change: [#8718] Allow TARMAC object to be removed when running the `remove_unused_objects` command. - Change: [#8718] No longer require the generic scenery groups and tarmac footpath to be checked when creating a scenario. - Change: [#8734] Disable kick button in multiplayer window when unable to use it. - Fix: [#3832] Changing the colour scheme of track pieces does not work in multiplayer. - Fix: [#4094] Coasters with long flat-to-steep pieces offer them in diagonal mode (original bug). - Fix: [#5684] Player list can desync between clients and server and can crash. - Fix: [#6191] OpenRCT2 fails to run when the path has an emoji in it. - Fix: [#7439] Placement messages have mixed strings - Fix: [#7473] Disabling sound effects also disables "Disable audio on focus loss". - Fix: [#7536] Android builds fail to start. - Fix: [#7689] Deleting 0-tile maze gives a MONEY32_UNDEFINED (negative) refund. - Fix: [#7828] Copied entrances and exits stay when demolishing ride. - Fix: [#7945] Client IP address is logged as `(null)` in server logs. - Fix: [#7952] Performance drop caused by code refactor. - Fix: [#7954] Key validation fails on Windows due to non-ASCII user / player name. - Fix: [#7975] Inspection flag not cleared for rides which are set to never be inspected (original bug). - Fix: [#7985] Giant Screenshot ignores 'Map rendering' settings. - Fix: [#7987] Broken track designs increase money by MONEY32_UNDEFINED. - Fix: [#7991] Scenery and footpaths on Construction Rights tiles can be deleted using Clear Scenery. - Fix: [#8034] Vanilla sprites are broken when making screenshots from command line. - Fix: [#8045] Crash when switching between languages. - Fix: [#8062] In multiplayer warnings for unstable cheats are shown when disabling them. - Fix: [#8090] Maze designs saved incorrectly. - Fix: [#8101] Title sequences window flashes after opening. - Fix: [#8120] Crash trying to place peep spawn outside of map. - Fix: [#8121] Crash Renaming park with server logging enabled. - Fix: [#8139] Buying land costs money when the game is in "no money" mode. - Fix: [#8141] Attempting to build entrance/exit on station 2 does not work. - Fix: [#8142] Reliability of mazes and crooked houses can go below 100%. - Fix: [#8187] Cannot set land ownership over ride entrances or exits in sandbox mode. - Fix: [#8200] Incorrect behaviour when removing entrances and exits that are on the same tile. - Fix: [#8204] Crash when tile element has no surface elements. - Fix: [#8264] Rides and scenery placeable outside of map with ZC and Sandbox mode enabled. - Fix: [#8335] Rides with arbitrary ride types can crash the game when they break down. - Fix: [#8358] Infinite loop when changing vehicle count on stopped ride. - Fix: [#8402] Crash closing a window in some cases. - Fix: [#8431] Crash when game action logging is enabled. - Fix: [#8433] Crash if master server response is not valid JSON. - Fix: [#8434] Crash if curl_easy_init fails. - Fix: [#8443] Crash when selecting the current vehicle for ride that has none available. - Fix: [#8456] Junior booster track piece doesn't connect properly. - Fix: [#8464] Crash on game shutdown. - Fix: [#8469] Crash modifying colour on hacked rides. - Fix: [#8508] Underground roto-drop is not going up. - Fix: [#8555] Multiplayer window text limits are not computed properly. - Fix: [#8572] Steel Twister track pieces ID 64 and 65 drawn incorrectly. - Fix: [#8585] Part of track missing on air powered vertical coaster. - Fix: [#8588] Guest list scrolling breaks above ~2000 guests. - Fix: [#8591] Game loop does not run at a consistent tick rate of 40 Hz. - Fix: [#8647] Marketing campaigns check for entry fees below £1 (original bug). - Fix: [#8653] Crash when peeps attempt to enter a ride with no vehicles. - Fix: [#8720] Desync due to boats colliding with ghost pieces. - Fix: [#8739] Savegame from original game crashes when cruising through map. - Fix: [#8742] Access violation in vehicle_update_sound_params. - Fix: [#8804] Raising water shows money effect at the bottom rather than new height. - Fix: [#8811] Some fields in the sv6 save file not being copied correctly. - Fix: [#8824] Invalid read in footpath_chain_ride_queue. - Improved: [#2940] Allow mouse-dragging to set patrol area (Singleplayer only). - Improved: [#7730] Draw extreme vertical and lateral Gs red in the ride window's graph tab. - Improved: [#7930] Automatically create folders for custom content. - Improved: [#7980] Show the full path of the scenario in the scenario select window. - Improved: [#7993] Allow assigning a keyboard shortcut for opening the tile inspector. - Improved: [#8107] Support Discord release of RCT2. - Improved: [#8491] Highlight entrance and exit with different colours in track design previews. - Improved: Almost completely new Hungarian translation. - Removed: [#7929] Support for scenario text objects.

Gymnasiast added this to the v0.2.2 milestone Oct 17, 2018

janisozaur force-pushed the breakpad-upload branch 7 times, most recently from 547d656 to 8ca1573 Compare October 18, 2018 20:31

IntelOrca reviewed Oct 18, 2018

View reviewed changes

janisozaur force-pushed the breakpad-upload branch from 78acad5 to 8c8c647 Compare October 24, 2018 13:08

janisozaur force-pushed the breakpad-upload branch 2 times, most recently from f7ad6e1 to 44b43f7 Compare October 24, 2018 14:14

janisozaur and others added 7 commits October 24, 2018 23:36

Auto-upload crashes to backtrace.io

23f9300

Add backtrace.io to "Sponsors" section

1f53789

Upload symbols from AppVeyor to backtrace.io

cc3beb9

Remove unnecessary opinion from comment

5ec03c7

Update minidump upload token

98aded2

Compress minidumps with gzip

2d95052

Use native path separators

3a83904

janisozaur force-pushed the breakpad-upload branch from 7166f40 to c8ef973 Compare October 24, 2018 21:50

Provide error messages after the dump has finished uploading

5780914

janisozaur force-pushed the breakpad-upload branch from c8ef973 to 5780914 Compare October 24, 2018 22:00

Disable gzip compression of dumps until this gets enabled on backtrace

7238ced

Fix messagebox buttons

76b6bd8

janisozaur mentioned this pull request Oct 25, 2018

BACKTRACE 709bfd #8157

Closed

IntelOrca approved these changes Oct 26, 2018

View reviewed changes

janisozaur merged commit 80b7575 into OpenRCT2:develop Oct 26, 2018

janisozaur deleted the breakpad-upload branch March 30, 2024 18:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto-upload crashes to backtrace.io #8073

Auto-upload crashes to backtrace.io #8073

janisozaur commented Oct 9, 2018 •

edited

Loading

janisozaur commented Oct 18, 2018

IntelOrca Oct 18, 2018

janisozaur Oct 19, 2018

IntelOrca Oct 18, 2018

janisozaur Oct 19, 2018

IntelOrca commented Oct 18, 2018

janisozaur commented Oct 19, 2018

IntelOrca commented Oct 19, 2018

janisozaur commented Oct 24, 2018 •

edited

Loading

janisozaur commented Oct 25, 2018

janisozaur commented Oct 25, 2018

Auto-upload crashes to backtrace.io #8073

Auto-upload crashes to backtrace.io #8073

Conversation

janisozaur commented Oct 9, 2018 • edited Loading

janisozaur commented Oct 18, 2018

IntelOrca Oct 18, 2018

Choose a reason for hiding this comment

janisozaur Oct 19, 2018

Choose a reason for hiding this comment

IntelOrca Oct 18, 2018

Choose a reason for hiding this comment

janisozaur Oct 19, 2018

Choose a reason for hiding this comment

IntelOrca commented Oct 18, 2018

janisozaur commented Oct 19, 2018

IntelOrca commented Oct 19, 2018

janisozaur commented Oct 24, 2018 • edited Loading

janisozaur commented Oct 25, 2018

janisozaur commented Oct 25, 2018

janisozaur commented Oct 9, 2018 •

edited

Loading

janisozaur commented Oct 24, 2018 •

edited

Loading