Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash after loading same saved file always happens a 1-2 mins after opening #8653

Closed
2 tasks
eperlow19 opened this issue Jan 30, 2019 · 16 comments
Closed
2 tasks

Comments

@eperlow19
Copy link

OS: [Windows 10]
Version: [0.2.1]
Commit/Build: [8ac731e]

<So openrct2 started crashing about 1 - 2 minutes after opening the same saved file each time. It does not matter whether i add scenery/build or just spectate: it seems to always crash. The error that comes up refers to an issue regarding "Sprite 65535" and i am not sure what that is or what it means. After clicking the abort option (the only proceed-able option), a window tells me to file the issue on github, with the dump and saved file/game. So here i am. Can someone please help? Thank you! This is a great community :)>

  • Reproducible in RCT2 (vanilla)?
  • Specific to multiplayer?

Steps to reproduce:

  1. Open saved game.

  2. Spectate or move around, and then about a minute or so in, it crashes.

Dump file

TVEdump.zip

Screenshots / Video:

2019-01-30

Save game:

treetopvalleyexpressway.zip

@janisozaur
Copy link
Member

@eperlow19
Copy link
Author

@janisozaur oh, im sorry i wasnt aware.. am i supposed to make an account on that website? it wont take my email....

@Gymnasiast
Copy link
Member

Gymnasiast commented Jan 30, 2019

@eperlow19 No, only we can access backtrace. It's a note for us.

I see you're using the 0.2.1 release. Could you test with the latest develop version instead? There is a good chance the crash has been solved.

@eperlow19
Copy link
Author

ah i see. And yeah sure - would that be the download at the openrct2 website called: (OpenRCT2-0.2.1-develop-3aad9a4-windows-win32.exe)?

@ZehMatt
Copy link
Member

ZehMatt commented Jan 30, 2019

The issue is still present, following line is the cause https://github.com/OpenRCT2/OpenRCT2/blob/develop/src/openrct2/peep/Guest.cpp#L2360

I think that assignment is not even necessary since the for-loop body will obtain it.

@janisozaur
Copy link
Member

@eperlow19 please disregard @Gymnasiast, he does not pay attention, you're already on the latest develop build.

@eperlow19
Copy link
Author

@janisozaur okay, at least i am up to date.. @ZehMatt so what do i do next?

@Gymnasiast
Copy link
Member

@janisozaur Then what is commit 8ac731e , mentioned in the first post?

@janisozaur
Copy link
Member

You wait until we fix it. We will provide an update here when that happens.

@janisozaur
Copy link
Member

@Gymnasiast a red herring.

@eperlow19
Copy link
Author

@janisozaur Okay. Thank you very much. Please know i have much respect for this kind of help. I will be on the look out for any updates :)

ZehMatt added a commit that referenced this issue Jan 30, 2019
Fix #8653: crash when peeps attempt to enter a ride with no vehicles.
@eperlow19
Copy link
Author

@ZehMatt so this is the issue? how do i apply this so that the save works again?

@janisozaur
Copy link
Member

You should be able to download an updated build and it should work correctly then

@eperlow19
Copy link
Author

@janisozaur so i should head over to the openrct2 website and get the most recent build (develop), and open the save file on that new version, correct?

@janisozaur
Copy link
Member

Yes

@eperlow19
Copy link
Author

@janisozaur It works again! thanks a lot guys! saved file has been running on the updated version and didnt crash. MUCH appreciated.

janisozaur added a commit that referenced this issue Mar 13, 2019
- Feature: [#4418] Allow steep slopes on the side-friction roller coaster.
- Feature: [#7726] Add shortcut to advance one tick.
- Feature: [#7956, #7964] Add sprite font glyphs for Hungarian and some Czech letters.
- Feature: [#7971] Toolbox option to open custom content folder.
- Feature: [#7980] Allow data path for RCT1 to be specified by a command line argument.
- Feature: [#8073] Auto-upload minidumps to backtrace.io (optional, MSVC/Windows only)
- Feature: [#8078] Add save_park command to in-game console.
- Feature: [#8080] New console variable "current_rotation" to get or set view rotation.
- Feature: [#8098] Glyph for Russian rouble sign.
- Feature: [#8099] Add Powered Launch mode to Inverted RC (for RCT1 parity).
- Feature: [#8190] Allow building footpaths on 'corner down' terrain.
- Feature: [#8191] Allow building on-ride photos and water S-bends on the Water Coaster.
- Feature: [#8259] Add say command to in-game console.
- Feature: [#8374] Add replay system.
- Feature: [#8377] Add option to adjust amount of autosaves to keep.
- Feature: [#8458] Add sprite sorting benchmark.
- Feature: [#8583] Add boosters to water coaster.
- Feature: [#8648] Add optional chat button to top toolbar in multiplayer games.
- Feature: [#8652] Add network window including a graph for data usage visualisation.
- Feature: [#8670] Add ability to download missing objects when loading a park.
- Change: [#7961] Add new object types: station, terrain surface, and terrain edge.
- Change: [#8222] The climate setting has been moved from objective options to scenario options.
- Change: [#8718] Allow TARMAC object to be removed when running the `remove_unused_objects` command.
- Change: [#8718] No longer require the generic scenery groups and tarmac footpath to be checked when creating a scenario.
- Change: [#8734] Disable kick button in multiplayer window when unable to use it.
- Fix: [#3832] Changing the colour scheme of track pieces does not work in multiplayer.
- Fix: [#4094] Coasters with long flat-to-steep pieces offer them in diagonal mode (original bug).
- Fix: [#5684] Player list can desync between clients and server and can crash.
- Fix: [#6191] OpenRCT2 fails to run when the path has an emoji in it.
- Fix: [#7439] Placement messages have mixed strings
- Fix: [#7473] Disabling sound effects also disables "Disable audio on focus loss".
- Fix: [#7536] Android builds fail to start.
- Fix: [#7689] Deleting 0-tile maze gives a MONEY32_UNDEFINED (negative) refund.
- Fix: [#7828] Copied entrances and exits stay when demolishing ride.
- Fix: [#7945] Client IP address is logged as `(null)` in server logs.
- Fix: [#7952] Performance drop caused by code refactor.
- Fix: [#7954] Key validation fails on Windows due to non-ASCII user / player name.
- Fix: [#7975] Inspection flag not cleared for rides which are set to never be inspected (original bug).
- Fix: [#7985] Giant Screenshot ignores 'Map rendering' settings.
- Fix: [#7987] Broken track designs increase money by MONEY32_UNDEFINED.
- Fix: [#7991] Scenery and footpaths on Construction Rights tiles can be deleted using Clear Scenery.
- Fix: [#8034] Vanilla sprites are broken when making screenshots from command line.
- Fix: [#8045] Crash when switching between languages.
- Fix: [#8062] In multiplayer warnings for unstable cheats are shown when disabling them.
- Fix: [#8090] Maze designs saved incorrectly.
- Fix: [#8101] Title sequences window flashes after opening.
- Fix: [#8120] Crash trying to place peep spawn outside of map.
- Fix: [#8121] Crash Renaming park with server logging enabled.
- Fix: [#8139] Buying land costs money when the game is in "no money" mode.
- Fix: [#8141] Attempting to build entrance/exit on station 2 does not work.
- Fix: [#8142] Reliability of mazes and crooked houses can go below 100%.
- Fix: [#8187] Cannot set land ownership over ride entrances or exits in sandbox mode.
- Fix: [#8200] Incorrect behaviour when removing entrances and exits that are on the same tile.
- Fix: [#8204] Crash when tile element has no surface elements.
- Fix: [#8264] Rides and scenery placeable outside of map with ZC and Sandbox mode enabled.
- Fix: [#8335] Rides with arbitrary ride types can crash the game when they break down.
- Fix: [#8358] Infinite loop when changing vehicle count on stopped ride.
- Fix: [#8402] Crash closing a window in some cases.
- Fix: [#8431] Crash when game action logging is enabled.
- Fix: [#8433] Crash if master server response is not valid JSON.
- Fix: [#8434] Crash if curl_easy_init fails.
- Fix: [#8443] Crash when selecting the current vehicle for ride that has none available.
- Fix: [#8456] Junior booster track piece doesn't connect properly.
- Fix: [#8464] Crash on game shutdown.
- Fix: [#8469] Crash modifying colour on hacked rides.
- Fix: [#8508] Underground roto-drop is not going up.
- Fix: [#8555] Multiplayer window text limits are not computed properly.
- Fix: [#8572] Steel Twister track pieces ID 64 and 65 drawn incorrectly.
- Fix: [#8585] Part of track missing on air powered vertical coaster.
- Fix: [#8588] Guest list scrolling breaks above ~2000 guests.
- Fix: [#8591] Game loop does not run at a consistent tick rate of 40 Hz.
- Fix: [#8647] Marketing campaigns check for entry fees below £1 (original bug).
- Fix: [#8653] Crash when peeps attempt to enter a ride with no vehicles.
- Fix: [#8720] Desync due to boats colliding with ghost pieces.
- Fix: [#8739] Savegame from original game crashes when cruising through map.
- Fix: [#8742] Access violation in vehicle_update_sound_params.
- Fix: [#8804] Raising water shows money effect at the bottom rather than new height.
- Fix: [#8811] Some fields in the sv6 save file not being copied correctly.
- Fix: [#8824] Invalid read in footpath_chain_ride_queue.
- Improved: [#2940] Allow mouse-dragging to set patrol area (Singleplayer only).
- Improved: [#7730] Draw extreme vertical and lateral Gs red in the ride window's graph tab.
- Improved: [#7930] Automatically create folders for custom content.
- Improved: [#7980] Show the full path of the scenario in the scenario select window.
- Improved: [#7993] Allow assigning a keyboard shortcut for opening the tile inspector.
- Improved: [#8107] Support Discord release of RCT2.
- Improved: [#8491] Highlight entrance and exit with different colours in track design previews.
- Improved: Almost completely new Hungarian translation.
- Removed: [#7929] Support for scenario text objects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants