Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal dialogue buttons should be right-aligned #4564

Closed
elebitzero opened this issue Feb 25, 2022 · 2 comments · Fixed by #4578
Closed

Modal dialogue buttons should be right-aligned #4564

elebitzero opened this issue Feb 25, 2022 · 2 comments · Fixed by #4578
Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Theme: UX/Usability Focuses on issues related to improving the overall user experience and interaction flow. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone

Comments

@elebitzero
Copy link
Member

Many of the modal dialogue buttons are left-aligned, while it is standard that they should be right-aligned

The following dialogs have the buttons left-aligned:

Export->Custom tabular exporter
Export-> SQL Exporter
Undo/Redo-> Extract operation history
Undo/Redo->Apply Operation History
All->Edit all columns->Transform
All->Edit all columns->Trim leading and trailing whitespace
All->Edit all columns->Collapse consecutive whitespace
All->Edit all columns->Unescape HTML entities
All->Edit all columns->Replace smart quotes with ASCII
All->Edit all columns->To titlecase
All->Edit all columns->To uppercase
All->Edit all columns->To lowercase
All->Edit all columns->To number
All->Edit all columns->To date
All->Edit all columns->To text
All->Edit all columns->To null
All->Edit all columns->To empty string
Column->Facet->Custom text facet on column
Column->Facet->Custom numeric facet on column
Column->Edit cells->Split multi-valued cells
Column->Edit cells->Join multi-valued cells
Column->Edit cells->Replace
Column->Edit Column->Transform
Column->Edit Column->Add column by fetching URLs based on column X
Column->Edit Column->Add column based on column X
Column->Edit Column->Split column X into several columns
Column->Edit Column->Join columns
Column->Transpose->Transpose cells across columns into rows...
Column->Transpose->Transpose cells in rows into columns...
Column->Transpose->Columnize by key/value columns...
Column->Sort
Column->Reconcile->Actions->Match all filtered cells to...
Column->Reconcile->Copy recon judgments from column X
Column->Reconcile->Use values as identifiers
Column->Reconcile->Add column containing entity identifiers on Bird

Proposed solution

Right-align the buttons in the listed dialogues

@elebitzero elebitzero added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Theme: UX/Usability Focuses on issues related to improving the overall user experience and interaction flow. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Feb 25, 2022
@wetneb wetneb removed the Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators label Feb 25, 2022
@wetneb
Copy link
Sponsor Member

wetneb commented Feb 25, 2022

Duplicate of #4457 (but I definitely agree)

@wetneb wetneb added the Status: Duplicate Assigned to issues that are exact duplicates of other open issues and  avoid duplicate discussions. label Feb 25, 2022
@wetneb
Copy link
Sponsor Member

wetneb commented Feb 25, 2022

Let's keep this issue since it has a nice review of the current state of dialogs.

@wetneb wetneb added Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. and removed Status: Duplicate Assigned to issues that are exact duplicates of other open issues and  avoid duplicate discussions. labels Feb 25, 2022
@wetneb wetneb added this to the 3.6 milestone Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Theme: UX/Usability Focuses on issues related to improving the overall user experience and interaction flow. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants