Initialize crypto API only once #1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 9e15848 into f52f306 - view on LGTM.com new alerts:
|
|
so this time tests/API/XCCDF/unittests/test_remediate_simple.sh passed therefore which means that it fails unreliably |
The function `crapi_init` calls `gcry_check_version` which must be called before any other function from the Libgcrypt library. That might be violated when multiple threads executing multiple probes are running. The mitigation proposed in this PR is to call `crapi_init` only once when the session is initialized which means before any threads are spawned. See also: https://www.gnupg.org/documentation/manuals/gcrypt/Multi_002dThreading.html#Multi_002dThreading Resolves: RHBZ#1959570
|
rebased on maint-1.3 |
jan-cerny
added a commit
to jan-cerny/openscap
that referenced
this pull request
Jul 28, 2021
The bug was a segmentation fault in filehash58 probe which happened in openscap-1.3.3-6.el8_3. The bug was fixed by OpenSCAP#1779 and this patch adds a very small test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
crapi_initcallsgcry_check_versionwhich must becalled before any other function from the Libgcrypt library. That might
be violated when multiple threads executing multiple probes are running.
The mitigation proposed in this PR is to call
crapi_initonly oncewhen the session is initialized which means before any threads are
spawned.
See also: https://www.gnupg.org/documentation/manuals/gcrypt/Multi_002dThreading.html#Multi_002dThreading
Resolves: RHBZ#1959570