Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Service Key on config file #104

Closed

Conversation

joel5vega
Copy link

Documentation about new feature adding availability to service key configuration

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@joel5vega
Copy link
Author

Hi @xmnlab , can you help me checking this PR

I have build the page and updated jupiter notebook

@@ -0,0 +1,351 @@
{
Copy link
Member

@xmnlab xmnlab Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has a bunch of text from the documentation, it is not necessary, just focus on introducing the new feature


Reply via ReviewNB

@@ -0,0 +1,351 @@
{
Copy link
Member

@xmnlab xmnlab Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #1.    ! pip install containers-sugar

use -q for the installation:

! pip install -q containers-sugar



Reply via ReviewNB

@@ -0,0 +1,351 @@
{
Copy link
Member

@xmnlab xmnlab Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this example, it is not necessary the .env


Reply via ReviewNB

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I remove the .env file I get this error
image

@@ -0,0 +1,351 @@
{
Copy link
Member

@xmnlab xmnlab Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this example just 1 service would be enough


Reply via ReviewNB

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -0,0 +1,351 @@
{
Copy link
Member

@xmnlab xmnlab Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the defaults and env-filehere is not necessary


Reply via ReviewNB

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happens with group config file
image

@@ -0,0 +1,351 @@
{
Copy link
Member

@xmnlab xmnlab Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaults and .env is not necessary


Reply via ReviewNB

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@@ -0,0 +1,351 @@
{
Copy link
Member

@xmnlab xmnlab Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this text looks like some text for makim


Reply via ReviewNB

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

@@ -0,0 +1,351 @@
{
Copy link
Member

@xmnlab xmnlab Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems you are mixing info from makim to sugar.


Reply via ReviewNB

@xmnlab
Copy link
Member

xmnlab commented Feb 21, 2024

@joel5vega , are you still up to work on this PR? if so, please check all my comments.
use chatgpt (or something similar) to improve the text, and use text just for sugar.
the text is mixed with makim text as well

@joel5vega
Copy link
Author

Yes @xmnlab , I will check it

@xmnlab
Copy link
Member

xmnlab commented Apr 21, 2024

@joel5vega , I am closing this PR because it is not moved since february.
feel free to re-open that when you start to work on that again! thank you!

@xmnlab xmnlab closed this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants