-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update function evaluator #81
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! There may be room for language improvement, but mainly about docs. I already changed a little bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks!
…urceEconomics/lcm into update-function-evaluator
In this PR, I update the code corresponding to the function evaluator.
function_evaluator.py
moduleFor example, we test the lookup with characters ["good", "bad"], which we do not want to support.
map_coordinates
to other interpolation tools, e.g.,RegularGridInterpolator
RegularGridInterpolator
implements a linear extrapolation feature. However, it is prohibitively slower compared tomap_coordinates.
Luckily, we can adjustmap_coordinates
to also perform linear extrapolation. See notes below.Note
map_coordinates
#83 for details.