Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang compilation fix #467

Closed
wants to merge 49 commits into from
Closed

Clang compilation fix #467

wants to merge 49 commits into from

Conversation

GeorgeIvlev
Copy link
Contributor

  • Resolve warnings related to bad comment string ( /** ... /**/ )
  • Fix logical warnings/errors on clang compilation
  • Fix critical code errors to be able to build project with clang
  • Fix critical errors in code
  • Update main CMakeLists file for better development experience
    • Added output for libraries to one place after build.
    • Group part of unix configuration into one block
  • Resolved couple of problems that was found in previous commits of this fix.

@Xottab-DUTY Xottab-DUTY added this to the Linux port milestone Sep 11, 2019
Xottab-DUTY
Xottab-DUTY requested changes Sep 12, 2019
View reviewed changes
src/xrSound/OpenALDeviceList.cpp Outdated Show resolved Hide resolved
src/xrUICore/ListWnd/UIListWnd_inline.h Outdated Show resolved Hide resolved
GeorgeIvlev and others added 13 commits September 16, 2019 22:51
@GeorgeIvlev @Xottab-DUTY
Update src/xrGame/game_sv_item_respawner.cpp
fa0df32 
- Restore formatting.

Co-Authored-By: Xottab_DUTY <Xottab-DUTY@users.noreply.github.com>
@GeorgeIvlev
Merge branch 'xd_dev-openxray' into xd_dev
26dbc56
@GeorgeIvlev
Merge branch 'xd_dev' into fix/clang_compilation
ec24250 
# Conflicts:
#	src/Layers/xrRenderPC_GL/r2_R_sun.cpp
@Xottab-DUTY @GeorgeIvlev
Fixed some not working smart covers in CS (#382)
f648cea
@Xottab-DUTY @GeorgeIvlev
Fixed Linux compilation
deb4a45
@eagleivg @GeorgeIvlev
xrCore: added getting date of files under Linux/FreeBSD
07f5e7a
@eagleivg @GeorgeIvlev
Common: implement file & directory remove on Linux
4913abe
@eagleivg @GeorgeIvlev
xrEngine: hide some SDL2 flags under version define (fix build on Ubu…
bf22f35 
…ntu16.04 with SDL2 v2.0.0)
@Xottab-DUTY @GeorgeIvlev
Removed SDL_WINDOW_SKIP_TASKBAR flag from splash screen
3ca586b 
It doesn't work on SDL 2.0.5 on Windows anyway and I find it fancy when splash screen is added to the taskbar.
@Xottab-DUTY @GeorgeIvlev
Fixed wrong vsprintf_s usage and linux compilation
ba47db3
@Xottab-DUTY @GeorgeIvlev
Fixed Linux compilation (honestly)
d1b642d
@vTurbine @GeorgeIvlev
xrCore: application title member added
a0c51bd
@Xottab-DUTY @GeorgeIvlev
Forgot to tell vsprintf_s about size...
543dbf7
Xottab-DUTY and others added 24 commits October 11, 2019 22:40
@Xottab-DUTY @GeorgeIvlev
xrRender_R*/r*_shaders.cpp: fixed possible crash when failed to disas…
c283edc 
…smble shader
@Xottab-DUTY @GeorgeIvlev
xrRender_R4/r4_shader.cpp: cleanup
4af25d9
@Xottab-DUTY @GeorgeIvlev
xrRender: resource managers and constants: use modern emplace_back an…
9fc1342 
…d emplace
@Xottab-DUTY @GeorgeIvlev
xrRender/ResourceManager.cpp: use range-based for loop
b9d7f62 
Also nullptr and some formatting.
@Xottab-DUTY @GeorgeIvlev
xrRender_R4: added support for non-unique named shader resources. (Cl…
bcb3515 
…oses #281)
@Xottab-DUTY @GeorgeIvlev
Prevent string concatenation crash on MASTER_GOLD
dba0bcd 
Matches original engine behaviour.
@Xottab-DUTY @GeorgeIvlev
Fixed crash at game start after ded6f18
66e09ff 
And fixed other possible issues
@vTurbine @GeorgeIvlev
xrRenderer: common types introduced
5d56f0d
@Xottab-DUTY @GeorgeIvlev
Fixed elite detector doesn't show artefacts (#382)
3474e52
@Xottab-DUTY @GeorgeIvlev
Merge pull request #485 from vTurbine/renderer/common_types
9a305b9 
xrRenderer: common types introduced
@Xottab-DUTY @GeorgeIvlev
[skip ci] Updated Clear Sky status
9653b5e
@Xottab-DUTY @GeorgeIvlev
Second fix to bloodsucker drag & jump in CS (#382)
7598aa4 
Addition to 610cac6
@Xottab-DUTY @GeorgeIvlev
Set different window title depending on game mode
5c8b0b0
@Xottab-DUTY @GeorgeIvlev
xr_3da/resource.rc: removed unused startup dialog
ffc9bee
@Xottab-DUTY @GeorgeIvlev
xr_3da/resource.rc: convert to UTF-8, fixed wrong Polish language ide…
6b98de9 
…ntifiers, resort
@Xottab-DUTY @GeorgeIvlev
xr_3da/resource.rc: resort and regeneration
48b8fe0
@Xottab-DUTY @GeorgeIvlev
xr_3da: added Clear Sky and Shadow of Chernobyl icons
d771fc1
@Xottab-DUTY @GeorgeIvlev
Set Clear Sky or Shadow of Chernobyl application icon if in the corre…
821d0cf 
…sponding mode

Refactored embedded resources management
@Xottab-DUTY @GeorgeIvlev
Always name threads created by SDL
4617258
@Xottab-DUTY @GeorgeIvlev
More correct way to fix DX9 fullscreen
7318749 
Rework of 32e64f5
@Xottab-DUTY @GeorgeIvlev
xrEngine/Device_create.cpp: made drawBorders static bool
acac196 
No need to always perform strstr, because the result won't change until
next launch.
@Xottab-DUTY @GeorgeIvlev
xrEngine/Device_create.cpp: replaced SDL_FALSE with SDL_DISABLE to su…
d4b7358 
…ppress warning about enum...
@Xottab-DUTY @GeorgeIvlev
Always switch display mode to fullscreen when it's selected (even for…
b43dc1d 
… DX9 renderer)

Because game looks ugly when using fullscreen desktop for DX9.
But DX9 itself will still behave as windowed.
@Xottab-DUTY @GeorgeIvlev
[skip ci] xrEngine/Device_initialize.cpp: just minor code swap
1e86d05
This was linked to issues Feb 28, 2020
[Linux] Clang build issues #289
Closed
Broken compilation with LLVM 8.0.1 #499
Closed
@Xottab-DUTY Xottab-DUTY added Code Quality Developer Experience Engine's programmer experience labels Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xottab-DUTY Xottab-DUTY Xottab-DUTY requested changes

@eagleivg eagleivg Awaiting requested review from eagleivg

Assignees
No one assigned
Labels
Code Quality Developer Experience Engine's programmer experience Portability
Projects
Roadmap
Status: Done
Milestone
Linux port
Development

Successfully merging this pull request may close these issues.

Broken compilation with LLVM 8.0.1 [Linux] Clang build issues
4 participants
@GeorgeIvlev @Xottab-DUTY @eagleivg @vTurbine