Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1CacheErrorInfo: code refactor for correct and convenient clockgate #3044

Merged
merged 2 commits into from
Jun 15, 2024
Merged

L1CacheErrorInfo: code refactor for correct and convenient clockgate #3044

merged 2 commits into from
Jun 15, 2024

Conversation

Maxpicca-Li
Copy link
Member

change the valid in the Bundle to the valid out of Bundle used ValidIO.

eastonman
eastonman approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@eastonman eastonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend part LGTM.

@Maxpicca-Li Maxpicca-Li added refactor Just make code pretty security Some designs may introduce security issues labels Jun 5, 2024
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 0da2b8b

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
0da2b8b 1.808 0.447 2.043 1.187 2.938 2.508 2.291 0.921 1.369 1.441 3.454 2.658 2.399 2.932

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
a7828dc 0.921 2.932
9f598f8
e975de6 1.808 0.447 2.043 1.187 2.938 2.508 2.291 0.921 1.369 1.441 3.454 2.658 2.399 2.932
ff9b84b 0.447 2.043 1.187 2.291 0.921 1.369 3.454 2.658 2.932
3bec463 1.808 0.447 2.043 1.187 2.938 2.508 2.291 0.921 1.369 1.441 3.454 2.658 2.399 2.932
2d12882 0.447 2.043 1.187 2.291 0.921 1.369 3.454 2.658 2.932
ef14270 1.827 0.448 2.048 1.190 2.938 2.508 2.289 0.932 1.369 1.410 3.445 2.672 2.398 2.932
5c5f442 1.827 0.448 2.048 1.190 2.938 2.508 2.289 0.932 1.369 1.410 3.445 2.672 2.398 2.932
d67c873 1.827 0.448 2.048 1.190 2.938 2.508 2.289 0.932 1.369 1.410 3.445 2.672 2.398 2.932

@Tang-Haojin Tang-Haojin merged commit 0184a80 into master Jun 15, 2024
4 checks passed
@Tang-Haojin Tang-Haojin deleted the code-valid-bundle-2406 branch June 15, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosscharlie bosscharlie bosscharlie approved these changes

@happy-lx happy-lx happy-lx approved these changes

@linjuanZ linjuanZ linjuanZ approved these changes

@eastonman eastonman eastonman approved these changes

@ssszwic ssszwic Awaiting requested review from ssszwic

Assignees
No one assigned
Labels
refactor Just make code pretty security Some designs may introduce security issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Maxpicca-Li @XiangShanRobot @eastonman @linjuanZ @happy-lx @bosscharlie @Tang-Haojin