Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timing of memblock #3062

Merged
merged 17 commits into from
Jun 18, 2024
Merged

Fix timing of memblock #3062

merged 17 commits into from
Jun 18, 2024

Conversation

good-circle
Copy link
Contributor

No description provided.

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: ab84e4b

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
ab84e4b 1.821 0.447 2.045 1.196 2.936 2.499 2.289 0.924 1.373 1.407 3.440 2.660 2.398 2.941

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
a7828dc
9f598f8
e975de6 1.808 0.447 2.043 1.187 2.938 2.508 2.291 0.921 1.369 1.441 3.454 2.658 2.399 2.932
ff9b84b 0.447 2.043 1.187 2.291 0.921 1.369 3.454 2.658 2.932
3bec463 1.808 0.447 2.043 1.187 2.938 2.508 2.291 0.921 1.369 1.441 3.454 2.658 2.399 2.932
2d12882 0.447 2.043 1.187 2.291 0.921 1.369 3.454 2.658 2.932
ef14270 1.827 0.448 2.048 1.190 2.938 2.508 2.289 0.932 1.369 1.410 3.445 2.672 2.398 2.932
5c5f442 1.827 0.448 2.048 1.190 2.938 2.508 2.289 0.932 1.369 1.410 3.445 2.672 2.398 2.932
d67c873 1.827 0.448 2.048 1.190 2.938 2.508 2.289 0.932 1.369 1.410 3.445 2.672 2.398 2.932

@weidingliu weidingliu force-pushed the memblock-fix-timing-240528 branch 2 times, most recently from 5c5a15b to 8ccaf18 Compare June 13, 2024 05:11
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 8ccaf18

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
8ccaf18 1.821 0.447 2.045 1.196 2.936 2.499 2.201 0.924 1.373 1.407 3.440 2.660 2.398 2.941

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
fcec058 1.808 2.043 1.187 2.938 2.508 0.921 1.369 1.441 3.454 2.399 2.932
0fbf39a 1.808 0.447 2.043 1.187 2.938 2.508 2.197 0.921 1.369 1.441 3.454 2.658 2.399 2.932
b37ee2e 1.808 0.447 2.043 1.187 2.938 2.508 2.197 0.921 1.369 1.441 3.454 2.658 2.399 2.932
b51d5c3 1.808 0.447 2.043 1.187 2.938 2.508 2.197 0.921 1.369 1.441 3.454 2.658 2.399 2.932
dd46182 1.808 0.447 2.043 1.187 2.938 2.508 2.197 0.921 1.369 1.441 3.454 2.658 2.399 2.932
49ceda6 1.808 0.447 2.043 1.187 2.938 2.508 2.197 0.921 1.369 1.441 3.454 2.658 2.399 2.932
a7828dc 1.808 0.447 2.043 1.187 2.938 2.508 2.291 0.921 1.369 1.441 3.454 2.658 2.399 2.932

cz4e and others added 15 commits June 14, 2024 13:08
@cz4e @weidingliu
ECC: physically disable tag ecc
02f1c95
@cz4e @weidingliu
Prefetcher: dont dynamically change pf confidence
d562d8a
@happy-lx @weidingliu
Prefetcher: use reg instead of wire when reordering for 3ld
d697c1c
@good-circle @weidingliu
PMP: optimize pmp timing (#2546)
2018e38
@cz4e @weidingliu
LoadQueueReplay: fix enq ready logic
ece3fff
@cz4e @weidingliu
LoadQueueRAW: simplify group logic
134812f
@cz4e @weidingliu
LoadQueueRAW: use grouped instead of sliding
eb12fd9
@cz4e @weidingliu
StoreQueue: fix st mmio uop selection
53c10d9
@cz4e @weidingliu
StoreQueue: fix forward logic
772a358
@good-circle @weidingliu
Dcache: data read valid should not rely on tag hit
6ac370b
@weidingliu
VMergeBuffer: refactor handshark between Split and MergeBuffer
b91db88
@weidingliu
VLSU: delay 1 cycle to ldu/stu for better timing
75b7040 
This commit add pipelineConnect between vlSplit/vsSplit and ldu/stu.
@weidingliu
VSplit: refactor ready signal send to higher-level flow
8957921 
This commit refactor ready signal's logic, which will get better timing
@weidingliu
Memblock: VsegmentUnit's tlb resquest delay 1 cycle & latch vaddr
98b5347 
This commit latch vaddr for merge Dcache's data and delay 1 cycle tlb request for better timing.
@weidingliu
VLSU: remove splitBuffer for timing
9ecab8f 
This commit remove SplitBuffer for better timing. The function of SplitBuffer is only used to store unsplit UOPs, and deletion has little impact.
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 9ecab8f

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
9ecab8f 1.821 0.447 2.045 1.196 2.936 2.499 2.201 0.924 1.373 1.407 3.440 2.660 2.398 2.941

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
26c1abd 2.039 1.378
fd3aa05 2.040 1.187 0.930 1.378 3.428 2.932
1b0de92 1.808 0.447 2.043 1.187 2.938 2.508 2.197 0.921 1.369 1.441 3.454 2.658 2.399 2.932
d8a998b 1.808 0.447 2.043 1.187 2.938 2.508 2.197 0.921 1.369 1.441 3.454 2.658 2.399 2.932
ee8d1f1 1.808 0.447 2.043 1.187 2.938 2.508 2.197 0.921 1.369 1.441 3.454 2.658 2.399 2.932
fcec058 1.808 0.447 2.043 1.187 2.938 2.508 2.197 0.921 1.369 1.441 3.454 2.658 2.399 2.932
0fbf39a 1.808 0.447 2.043 1.187 2.938 2.508 2.197 0.921 1.369 1.441 3.454 2.658 2.399 2.932

@weidingliu weidingliu added the timing Fix bad timing label Jun 16, 2024
@good-circle good-circle marked this pull request as ready for review June 17, 2024 01:27
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: eb093eb

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
eb093eb 1.809 0.452 2.052 1.196 2.951 2.499 2.197 0.930 1.377 1.407 3.436 2.653 2.398 2.941

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
5adc482 1.801 0.452 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
0d257fb 1.801 0.452 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
ba5ba1d 1.805 0.452 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
6613a2d 1.801 0.448 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
9810c04 1.805 0.448 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
0184a80 1.803 0.448 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
8fe4f15 1.805 0.448 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
54cc3a0 1.805 0.448 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
26c1abd 1.803 0.448 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
fd3aa05 1.803 0.448 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932

@Tang-Haojin Tang-Haojin merged commit a31db3f into master Jun 18, 2024
6 checks passed
@Tang-Haojin Tang-Haojin deleted the memblock-fix-timing-240528 branch June 18, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidingliu weidingliu weidingliu approved these changes

@cz4e cz4e cz4e approved these changes

@linjuanZ linjuanZ linjuanZ approved these changes

@happy-lx happy-lx happy-lx approved these changes

@Maxpicca-Li Maxpicca-Li Maxpicca-Li approved these changes

@bosscharlie bosscharlie bosscharlie approved these changes

Assignees
No one assigned
Labels
timing Fix bad timing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@good-circle @XiangShanRobot @cz4e @linjuanZ @weidingliu @happy-lx @Maxpicca-Li @bosscharlie @Tang-Haojin