Fix Docker build issues and improve chain-agnostic architecture #52
Conversation
👷 Deploy request for transaction-form-builder pending review.A Netlify team Owner will need to approve the deploy before you can run your build. Are you a team Owner? Visit the deploys page to approve it → Need more help? Learn more in the Netlify docs →
|
🚨 BugBot couldn't runSomething went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_dc7b0435-a231-42ef-9f87-0dc56f5bac76). |
There was a problem hiding this comment.
Pull Request Overview
This PR resolves Docker build issues when building from a clean repository clone and improves the chain-agnostic architecture by removing EVM-specific dependencies from shared packages.
- Docker build process now compiles all workspace packages in dependency order using
pnpm -r build - EVM-specific
viemimports removed from chain-agnostic types package - New
TypedEvmNetworkConfiginterface added to EVM adapter for proper type safety while maintaining base compatibility
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Dockerfile | Changed build command to compile all workspace packages in dependency order |
| packages/types/src/networks/config.ts | Removed viem import and changed viemChain type to unknown for chain-agnostic compatibility |
| packages/adapter-evm/src/types.ts | Added TypedEvmNetworkConfig interface with proper viem Chain typing |
| packages/adapter-evm/src/adapter.ts | Updated to use TypedEvmNetworkConfig instead of EvmNetworkConfig |
| packages/builder/src/core/ecosystemManager.ts | Updated import and type usage for TypedEvmNetworkConfig |
| Multiple package.json files | Updated react-hook-form versions and added missing dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
packages/adapter-evm/src/networks/testnet.ts:193
- [nitpick] The variable name
zksyncSepoliaTestnetis inconsistent with theexportConstNameproperty value'zksyncSepoliaTestnet'but inconsistent with the previous naming pattern. The original namezkSyncEraSepoliawas more descriptive and consistent with other network names.
export const zksyncSepoliaTestnet: TypedEvmNetworkConfig = {
packages/adapter-evm/src/networks/testnet.ts:195
- [nitpick] The
exportConstNameshould match the variable name for consistency. If the variable iszksyncSepoliaTestnet, the export name should also bezksyncSepoliaTestnet, but this creates inconsistency with other networks that use camelCase without the 'testnet' suffix.
exportConstName: 'zksyncSepoliaTestnet',
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ BugBot reviewed your changes and found no bugs!
BugBot free trial expires on July 22, 2025
Learn more in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
Summary
Resolves Docker build failures when building from a clean repository clone and improves the separation between chain-agnostic and EVM-specific code.
Key Changes
pnpm -r build)viemimports from chain-agnostic@openzeppelin/contracts-ui-builder-typespackageTypedEvmNetworkConfiginterface in EVM adapter for properviem.Chaintyping while maintaining base type compatibilitylucide-reactandreact-hook-formdependencies to packages that were importing them