Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Script Task use Monaco Editor #10715

Merged
merged 5 commits into from
Feb 2, 2022

Conversation

hyzx86
Copy link
Contributor

@hyzx86 hyzx86 commented Nov 17, 2021

image

@hyzx86 hyzx86 requested a review from sfmskywalker as a code owner November 17, 2021 10:55
@deanmarcussen
Copy link
Member

I don't get it. On a previous pr you are introducing the codemirror editor, then here the monaco editor?

@hyzx86
Copy link
Contributor Author

hyzx86 commented Nov 30, 2021

Previous PR was primarily about fixing bugs, and I'm not sure how many workflow activities require the JavaScript editor, which I personally think is necessary to update scripting tasks, which are more commonly used after all.

@deanmarcussen
Copy link
Member

Anyone have any objections to this, or I will merge it?

@MichaelPetrinolis
Copy link
Contributor

I think it's cool to have the monaco javascript editor here. In a next PR we could extend the editor's intellisense with the workflow context.

@giannik
Copy link
Contributor

giannik commented Feb 2, 2022 via email

@deanmarcussen deanmarcussen merged commit 7ccd04f into OrchardCMS:main Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants