-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the Script Task use Monaco Editor #10715
Conversation
hyzx86
commented
Nov 17, 2021
I don't get it. On a previous pr you are introducing the codemirror editor, then here the monaco editor? |
Previous PR was primarily about fixing bugs, and I'm not sure how many workflow activities require the JavaScript editor, which I personally think is necessary to update scripting tasks, which are more commonly used after all. |
… into workflow-monaco
Anyone have any objections to this, or I will merge it? |
I think it's cool to have the monaco javascript editor here. In a next PR we could extend the editor's intellisense with the workflow context. |
Please merge.
The greeks want it.
…On Wed, Feb 2, 2022 at 2:52 PM Michael Petrinolis ***@***.***> wrote:
I think it's cool to have the monaco javascript editor here. In a next PR
we could extend the editor's intellisense with the workflow context.
—
Reply to this email directly, view it on GitHub
<#10715 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALSLNIA6GTN73GI2GBTEG3UZESINANCNFSM5IGTXJRA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|